Open Ash shell after creating Profile

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 212 matching lines @@
        ++it) {
     // Delete both the profile directory and its corresponding cache.
     base::FilePath cache_path;
     chrome::GetUserCacheDirectory(*it, &cache_path);
     file_util::Delete(*it, true);
     file_util::Delete(cache_path, true);
   }
   ProfilesToDelete().clear();
 }
 
+namespace {
+// Assume "allowed" for tests; SetAllowGetDefaultProfile(false) should be called

[sail, 2013/05/23 18:20:56]

new line before

[stevenjb, 2013/05/23 18:28:15]

Done.

+// early to enable checking, e.g. from ChromeBrowserMainParts.
+bool s_allow_get_default_profile = true;
+}

[sail, 2013/05/23 18:20:56]

new line before

[stevenjb, 2013/05/23 18:28:15]

Done.

+
+// static
+void ProfileManager::SetAllowGetDefaultProfile(bool allow) {
+  s_allow_get_default_profile = allow;
+}
+
 // static
 // TODO(nkostylev): Remove this method once all clients are migrated.
 Profile* ProfileManager::GetDefaultProfile() {
+  LOG_IF(FATAL, !s_allow_get_default_profile)

[sail, 2013/05/23 18:20:56]

can we make this a CHECK() instead?

[stevenjb, 2013/05/23 18:28:15]

Done.

+      << "GetDefaultProfile() caled befofre allowed.";
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   return profile_manager->GetDefaultProfile(profile_manager->user_data_dir_);
 }
 
 // static
 // TODO(nkostylev): Remove this method once all clients are migrated.
 Profile* ProfileManager::GetDefaultProfileOrOffTheRecord() {
+  LOG_IF(FATAL, !s_allow_get_default_profile)
+      << "GetDefaultProfileOrOffTheRecord() caled befofre allowed.";
   // TODO (mukai,nkostylev): In the long term we should fix those cases that
   // crash on Guest mode and have only one GetDefaultProfile() method.
   Profile* profile = GetDefaultProfile();
 #if defined(OS_CHROMEOS)
   if (chromeos::UserManager::Get()->IsLoggedInAsGuest())
     profile = profile->GetOffTheRecordProfile();
 #endif
   return profile;
 }
 
@@ skipping 911 matching lines @@
 ProfileManager::ProfileInfo::ProfileInfo(
     Profile* profile,
     bool created)
     : profile(profile),
       created(created) {
 }
 
 ProfileManager::ProfileInfo::~ProfileInfo() {
   ProfileDestroyer::DestroyProfileWhenAppropriate(profile.release());
 }