Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: pkg/analyzer/lib/src/summary/flat_buffers.dart

Issue 1570193004: Remove Int64 support from FlatBuffers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/flat_buffers_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/flat_buffers.dart
diff --git a/pkg/analyzer/lib/src/summary/flat_buffers.dart b/pkg/analyzer/lib/src/summary/flat_buffers.dart
index 5c1df2e66413c5589a11d1a2b0457e2ffd4707e0..5c62da6534d9cb5cc6609a8cbe4c623561fe683a 100644
--- a/pkg/analyzer/lib/src/summary/flat_buffers.dart
+++ b/pkg/analyzer/lib/src/summary/flat_buffers.dart
@@ -39,9 +39,6 @@ class BufferPointer {
int _getInt32([int delta = 0]) =>
_buffer.getInt32(_offset + delta, Endianness.LITTLE_ENDIAN);
- int _getInt64([int delta = 0]) =>
- _buffer.getInt64(_offset + delta, Endianness.LITTLE_ENDIAN);
-
int _getInt8([int delta = 0]) => _buffer.getInt8(_offset + delta);
int _getUint16([int delta = 0]) =>
@@ -118,22 +115,6 @@ class Builder {
}
/**
- * Add the [field] with the given 64-bit signed integer [value]. The field is
- * not added if the [value] is equal to [def].
- */
- void addInt64(int field, int value, [int def]) {
- if (_currentVTable == null) {
- throw new StateError('Start a table before adding values.');
- }
- if (value != def) {
- int size = 8;
- _prepare(size, 1);
- _trackField(field);
- _setInt64AtTail(_buf, _tail, value);
- }
- }
-
- /**
* Add the [field] with the given 8-bit signed integer [value]. The field is
* not added if the [value] is equal to [def].
*/
@@ -241,14 +222,6 @@ class Builder {
/**
* This is a low-level method, it should not be invoked by clients.
*/
- void lowWriteUint64(int value) {
- _prepare(8, 1);
- _setUint64AtTail(_buf, _tail, value);
- }
-
- /**
- * This is a low-level method, it should not be invoked by clients.
- */
void lowWriteUint8(int value) {
_prepare(1, 1);
_buf.setUint8(_buf.lengthInBytes - _tail, value);
@@ -384,17 +357,9 @@ class Builder {
_buf.setInt32(_buf.lengthInBytes - tail, x, Endianness.LITTLE_ENDIAN);
}
- static void _setInt64AtTail(ByteData _buf, int tail, int x) {
- _buf.setInt64(_buf.lengthInBytes - tail, x, Endianness.LITTLE_ENDIAN);
- }
-
static void _setUint32AtTail(ByteData _buf, int tail, int x) {
_buf.setUint32(_buf.lengthInBytes - tail, x, Endianness.LITTLE_ENDIAN);
}
-
- static void _setUint64AtTail(ByteData _buf, int tail, int x) {
- _buf.setUint64(_buf.lengthInBytes - tail, x, Endianness.LITTLE_ENDIAN);
- }
}
/**
@@ -411,19 +376,6 @@ class Int32Reader extends Reader<int> {
}
/**
- * The reader of 64-bit signed integers.
- */
-class Int64Reader extends Reader<int> {
- const Int64Reader() : super();
-
- @override
- int get size => 8;
-
- @override
- int read(BufferPointer bp) => bp._getInt64();
-}
-
-/**
* The reader of 8-bit signed integers.
*/
class Int8Reader extends Reader<int> {
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/flat_buffers_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698