Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/ui/cocoa/location_bar/content_setting_bubble_views_mac.h

Issue 1570153003: Use MacViews for ContentSettingBubbles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/content_setting_bubble_views_mac.h
diff --git a/chrome/browser/ui/cocoa/location_bar/content_setting_bubble_views_mac.h b/chrome/browser/ui/cocoa/location_bar/content_setting_bubble_views_mac.h
new file mode 100644
index 0000000000000000000000000000000000000000..0b24e9cc27f309ae6f75b915e5a85bb1336002f2
--- /dev/null
+++ b/chrome/browser/ui/cocoa/location_bar/content_setting_bubble_views_mac.h
@@ -0,0 +1,25 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
tapted 2016/01/11 02:50:57 nit: no `(c)`, more in other files.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
tapted 2016/01/11 02:50:57 #include guards? also stuff under c/b/ui/cocoa do
+#include "ui/gfx/geometry/point.h"
+#include "ui/views/widget/widget.h"
+
+class ContentSettingBubbleModel;
+namespace content {
+class WebContents;
+}
+
+// This class bridges a views ContentSettingBubbleContents so it can be used by
+// the Cocoa location bar code.
+class ContentSettingBubbleBridge {
+ public:
+ ContentSettingBubbleBridge(ContentSettingBubbleModel* model,
tapted 2016/01/11 02:50:57 I think this can just be a standalone function tha
+ content::WebContents* web_contents,
+ const gfx::Point& anchor);
+ ~ContentSettingBubbleBridge();
+
+ void Show();
+ private:
tapted 2016/01/11 02:50:57 nit: blank line before
+ views::Widget* bubble_widget_;
+};
tapted 2016/01/11 02:50:57 nit: DISALLOW_COPY_AND_ASSIGN(..)

Powered by Google App Engine
This is Rietveld 408576698