Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: chrome/browser/ui/cocoa/location_bar/content_setting_bubble_views_mac.mm

Issue 1570153003: Use MacViews for ContentSettingBubbles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
tapted 2016/01/11 02:50:57 can this be .cc instead of .mm?
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/cocoa/location_bar/content_setting_bubble_views_mac. h"
tapted 2016/01/11 02:50:57 nit: blank line after the #include for a .cc's cor
6 #include "chrome/browser/ui/views/content_setting_bubble_contents.h"
7
8 ContentSettingBubbleBridge::ContentSettingBubbleBridge(
9 ContentSettingBubbleModel* model,
10 content::WebContents* web_contents,
11 const gfx::Point& anchor) {
12 ContentSettingBubbleContents* contents =
13 new ContentSettingBubbleContents(model,
14 web_contents, NULL,
tapted 2016/01/11 02:50:57 nit: NULL -> nullptr
15 views::BubbleBorder::Arrow::TOP_RIGHT);
tapted 2016/01/11 02:50:57 I *think* CreateBubbleWidget(..) in ui/views/bubbl
16 contents->SetExplicitAnchorRect(gfx::Rect(anchor, gfx::Size(0, 0)));
tapted 2016/01/11 02:50:57 nit: Size(0, 0) -> Size()
17 bubble_widget_ = views::BubbleDelegateView::CreateBubble(contents);
18 }
19
20 ContentSettingBubbleBridge::~ContentSettingBubbleBridge() {}
21
22 void ContentSettingBubbleBridge::Show() {
23 bubble_widget_->Show();
24 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698