Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1570133004: Endless tidying in pageint.h (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Endless tidying in pageint.h Remove unused enum. Don't begin struct names with underscore. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d8ea0c8f4976d12b52de37b81e80d08c8fab5589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -88 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 6 chunks +9 lines, -85 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, small cleanup.
4 years, 11 months ago (2016-01-08 21:28:16 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-08 21:29:46 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-08 21:57:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8ea0c8f4976d12b52de37b81e80d08c8fab5589 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698