Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: Source/core/html/HTMLFormControlsCollection.idl

Issue 157013006: Update HTMLFormControlsCollection's named getter to behave according to spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline inspector test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormControlsCollection.idl
diff --git a/Source/core/html/HTMLFormControlsCollection.idl b/Source/core/html/HTMLFormControlsCollection.idl
index aeb9a1ec229328c71928a9775eefea16a3862739..06e5c342deb4bf068d1c1b0af4d7bdf48ce2776b 100644
--- a/Source/core/html/HTMLFormControlsCollection.idl
+++ b/Source/core/html/HTMLFormControlsCollection.idl
@@ -1,6 +1,7 @@
/*
* Copyright (C) 2006, 2007, 2012 Apple Inc. All rights reserved.
* Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
+ * Copyright (C) 2014 Samsung Electronics. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -23,6 +24,5 @@
SetWrapperReferenceFrom=ownerNode,
] interface HTMLFormControlsCollection : HTMLCollection {
[ImplementedAs=item] getter Node (unsigned long index);
- [Custom] Element namedItem([Default=Undefined] optional DOMString name);
- [ImplementedAs=namedGetter, NotEnumerable] getter (RadioNodeList or Element) (DOMString name);
+ [ImplementedAs=namedGetter] legacycaller getter (RadioNodeList or Element) namedItem(DOMString name); // shadows inherited namedItem()
Nils Barth (inactive) 2014/02/07 01:40:43 legacycaller is currently a nop; do you want to om
Inactive 2014/02/07 01:52:38 I know it is a noop but the parser doesn't mind it
Nils Barth (inactive) 2014/02/07 01:54:56 I'd rather not include undocumented nops, since it
};
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698