Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: Source/core/html/HTMLFormControlsCollection.h

Issue 157013006: Update HTMLFormControlsCollection's named getter to behave according to spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove legacycaller Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLCollection.cpp ('k') | Source/core/html/HTMLFormControlsCollection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.
5 * Copyright (C) 2014 Samsung Electronics. All rights reserved.
5 * 6 *
6 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
10 * 11 *
11 * This library is distributed in the hope that it will be useful, 12 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of 13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details. 15 * Library General Public License for more details.
(...skipping 21 matching lines...) Expand all
36 // This class is just a big hack to find form elements even in malformed HTML el ements. 37 // This class is just a big hack to find form elements even in malformed HTML el ements.
37 // The famous <table><tr><form><td> problem. 38 // The famous <table><tr><form><td> problem.
38 39
39 class HTMLFormControlsCollection FINAL : public HTMLCollection { 40 class HTMLFormControlsCollection FINAL : public HTMLCollection {
40 public: 41 public:
41 static PassRefPtr<HTMLFormControlsCollection> create(ContainerNode*, Collect ionType); 42 static PassRefPtr<HTMLFormControlsCollection> create(ContainerNode*, Collect ionType);
42 43
43 virtual ~HTMLFormControlsCollection(); 44 virtual ~HTMLFormControlsCollection();
44 45
45 virtual Element* namedItem(const AtomicString& name) const OVERRIDE; 46 virtual Element* namedItem(const AtomicString& name) const OVERRIDE;
46 void namedGetter(const AtomicString& name, bool&, RefPtr<RadioNodeList>&, bo ol&, RefPtr<Element>&); 47 void namedGetter(const AtomicString& name, bool& radioNodeListEnabled, RefPt r<RadioNodeList>&, bool& elementEnabled, RefPtr<Element>&);
47 48
48 private: 49 private:
49 explicit HTMLFormControlsCollection(ContainerNode*); 50 explicit HTMLFormControlsCollection(ContainerNode*);
50 51
51 virtual void updateNameCache() const OVERRIDE; 52 virtual void updateNameCache() const OVERRIDE;
53 virtual void supportedPropertyNames(Vector<String>& names) OVERRIDE;
52 54
53 const Vector<FormAssociatedElement*>& formControlElements() const; 55 const Vector<FormAssociatedElement*>& formControlElements() const;
54 const Vector<HTMLImageElement*>& formImageElements() const; 56 const Vector<HTMLImageElement*>& formImageElements() const;
55 virtual Element* virtualItemAfter(Element*) const OVERRIDE; 57 virtual Element* virtualItemAfter(Element*) const OVERRIDE;
56 virtual void invalidateCache() const OVERRIDE; 58 virtual void invalidateCache() const OVERRIDE;
57 59
58 mutable Element* m_cachedElement; 60 mutable Element* m_cachedElement;
59 mutable unsigned m_cachedElementOffsetInArray; 61 mutable unsigned m_cachedElementOffsetInArray;
60 }; 62 };
61 63
62 } // namespace 64 } // namespace
63 65
64 #endif 66 #endif
OLDNEW
« no previous file with comments | « Source/core/html/HTMLCollection.cpp ('k') | Source/core/html/HTMLFormControlsCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698