Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: Source/core/html/HTMLCollection.cpp

Issue 157013006: Update HTMLFormControlsCollection's named getter to behave according to spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove legacycaller Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLCollection.h ('k') | Source/core/html/HTMLFormControlsCollection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved.
5 * Copyright (C) 2014 Samsung Electronics. All rights reserved. 5 * Copyright (C) 2014 Samsung Electronics. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
519 if (!idAttribute.isEmpty()) { 519 if (!idAttribute.isEmpty()) {
520 HashSet<AtomicString>::AddResult addResult = existingNames.add(idAtt ribute); 520 HashSet<AtomicString>::AddResult addResult = existingNames.add(idAtt ribute);
521 if (addResult.isNewEntry) 521 if (addResult.isNewEntry)
522 names.append(idAttribute); 522 names.append(idAttribute);
523 } 523 }
524 } 524 }
525 } 525 }
526 526
527 void HTMLCollection::namedPropertyEnumerator(Vector<String>& names, ExceptionSta te&) 527 void HTMLCollection::namedPropertyEnumerator(Vector<String>& names, ExceptionSta te&)
528 { 528 {
529 return supportedPropertyNames(names); 529 supportedPropertyNames(names);
530 } 530 }
531 531
532 void HTMLCollection::updateNameCache() const 532 void HTMLCollection::updateNameCache() const
533 { 533 {
534 if (hasNameCache()) 534 if (hasNameCache())
535 return; 535 return;
536 536
537 ContainerNode& root = rootNode(); 537 ContainerNode& root = rootNode();
538 for (Element* element = traverseToFirstElement(root); element; element = tra verseNextElement(*element, root)) { 538 for (Element* element = traverseToFirstElement(root); element; element = tra verseNextElement(*element, root)) {
539 const AtomicString& idAttrVal = element->getIdAttribute(); 539 const AtomicString& idAttrVal = element->getIdAttribute();
(...skipping 29 matching lines...) Expand all
569 569
570 void HTMLCollection::append(NodeCacheMap& map, const AtomicString& key, Element* element) 570 void HTMLCollection::append(NodeCacheMap& map, const AtomicString& key, Element* element)
571 { 571 {
572 OwnPtr<Vector<Element*> >& vector = map.add(key.impl(), nullptr).iterator->v alue; 572 OwnPtr<Vector<Element*> >& vector = map.add(key.impl(), nullptr).iterator->v alue;
573 if (!vector) 573 if (!vector)
574 vector = adoptPtr(new Vector<Element*>); 574 vector = adoptPtr(new Vector<Element*>);
575 vector->append(element); 575 vector->append(element);
576 } 576 }
577 577
578 } // namespace WebCore 578 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLCollection.h ('k') | Source/core/html/HTMLFormControlsCollection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698