Update HTMLFormControlsCollection's named getter to behave according to spec

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
-# Copyright (C) 2013 Samsung Electronics. All rights reserved.
+# Copyright (C) 2013, 2014 Samsung Electronics. All rights reserved.
 #
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Library General Public
 # License as published by the Free Software Foundation; either
 # version 2 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 # Library General Public License for more details.
@@ skipping 3554 matching lines @@
 }
 
 sub GenerateIsNullExpression
 {
     my $type = shift;
     my $variableName = shift;
     if (IsUnionType($type)) {
         my $types = $type->unionMemberTypes;
         my @expression = ();
         for my $i (0 .. scalar(@$types)-1) {
-            my $unionMemberType = $types->[$i];
-            my $unionMemberVariable = $variableName . $i;
-            my $isNull = GenerateIsNullExpression($unionMemberType, $unionMemberVariable);
-            push @expression, $isNull;
+            my $unionMemberEnabledVariable = $variableName . $i . "Enabled";
+            push @expression, "!${unionMemberEnabledVariable}";
         }
         return join " && ", @expression;
     }
     if (IsRefPtrType($type)) {
         return "!${variableName}";
     } elsif ($type eq "DOMString") {
         return "${variableName}.isNull()";
     } elsif ($type eq "Promise") {
         return "${variableName}.isNull()";
     } else {
@@ skipping 492 matching lines @@
     $code .= "    ${implClassName}* collection = ${v8ClassName}::toNative(info.Holder());\n";
     $code .= "    AtomicString propertyName = toCoreAtomicString(name);\n";
     if ($raisesExceptions) {
         $code .= "    ExceptionState exceptionState(info.Holder(), info.GetIsolate());\n";
     }
     $code .= $methodCallCode . "\n";
     if ($raisesExceptions) {
         $code .= "    if (exceptionState.throwIfNeeded())\n";
         $code .= "        return;\n";
     }
-    if (IsUnionType($returnType)) {
-        $code .= "${returnJSValueCode}\n";
-        $code .= "    return;\n";
-    } else {
-        $code .= "    if (${isNull})\n";
-        $code .= "        return;\n";
-        $code .= $returnJSValueCode . "\n";
-    }
+    $code .= "    if (${isNull})\n";
+    $code .= "        return;\n";
+    $code .= $returnJSValueCode . "\n";
     $code .= "}\n\n";
     $implementation{nameSpaceInternal}->add($code);
 }
 
 sub GenerateImplementationNamedPropertySetter
 {
     my $interface = shift;
     my $namedSetterFunction = shift;
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
@@ skipping 1153 matching lines @@
     my $indent = shift;
     my $interface = shift;
     my $forMainWorldSuffix = shift;
     my $hasExceptionState = shift;
     my %replacements = @_;
 
     my $interfaceName = $interface->name;
     my $implClassName = GetImplName($interface);
     my $name = GetImplName($function);
     my $returnType = $function->type;
-    my $nativeReturnType = GetNativeType($returnType, {}, "");
     my $code = "";
-
     my $isSVGTearOffType = (IsSVGTypeNeedingTearOff($returnType) and not $interfaceName =~ /List$/);
-    $nativeReturnType = GetSVGWrappedTypeNeedingTearOff($returnType) if $isSVGTearOffType;
 
     my $index = 0;
     my $humanFriendlyIndex = $index + 1;
 
     my @arguments;
     my $functionName;
     my $implementedBy = $function->extendedAttributes->{"ImplementedBy"};
     if ($implementedBy) {
         my $implementedByImplName = GetImplNameFromImplementedBy($implementedBy);
         AddToImplIncludes(HeaderFilesForInterface($implementedBy, $implementedByImplName));
@@ skipping 47 matching lines @@
             push @arguments, "${paramName}IsNull ? 0 : &$paramName";
         } elsif (IsCallbackInterface($paramType) or $paramType eq "NodeFilter" or $paramType eq "XPathNSResolver") {
             push @arguments, "$paramName.release()";
         } else {
             push @arguments, $paramName;
         }
         $index++;
         $humanFriendlyIndex = $index + 1;
     }
 
+    # Support for returning a union type.
+    if (IsUnionType($returnType)) {
+        my $types = $returnType->unionMemberTypes;
+        for my $i (0 .. scalar(@$types)-1) {
+            my $unionMemberType = $types->[$i];
+            my $unionMemberNativeType = GetNativeType($unionMemberType);
+            my $unionMemberNumber = $i + 1;
+            my $unionMemberVariable = "result" . $i;
+            my $unionMemberEnabledVariable = "result" . $i . "Enabled";
+            $code .= "    bool ${unionMemberEnabledVariable} = false;\n";
+            $code .= "    ${unionMemberNativeType} ${unionMemberVariable};\n";
+            push @arguments, $unionMemberEnabledVariable;
+            push @arguments, $unionMemberVariable;
+        }
+    }
+
     if ($function->extendedAttributes->{"RaisesException"}) {
         push @arguments, "exceptionState";
     }
 
     my $functionString = "$functionName(" . join(", ", @arguments) . ")";
 
     my $return = "result";
     my $returnIsRef = IsRefPtrType($returnType);
 
-    if ($returnType eq "void") {
+    if ($returnType eq "void" || IsUnionType($returnType)) {
         $code .= $indent . "$functionString;\n";
     } elsif (ExtendedAttributeContains($callWith, "ScriptState") or $function->extendedAttributes->{"RaisesException"}) {
+        my $nativeReturnType = GetNativeType($returnType, {}, "");
+        $nativeReturnType = GetSVGWrappedTypeNeedingTearOff($returnType) if $isSVGTearOffType;
+
         $code .= $indent . $nativeReturnType . " result = $functionString;\n";
     } else {
         # Can inline the function call into the return statement to avoid overhead of using a Ref<> temporary
         $return = $functionString;
         $returnIsRef = 0;
 
         if ($interfaceName eq "SVGTransformList" and IsRefPtrType($returnType)) {
             $return = "WTF::getPtr(" . $return . ")";
         }
     }
@@ skipping 345 matching lines @@
               $code .= "${indent}if (${unionMemberEnabledVariable}) {\n";
               $code .= "${returnJSValueCode}\n";
               $code .= "${indent}    return;\n";
               $code .= "${indent}}\n";
             } else {
               $code .= "${indent}if (${unionMemberEnabledVariable})\n";
               $code .= "${returnJSValueCode}";
             }
             push @codes, $code;
         }
+        if ($isReturnValue) {
+            # Fall back to returning null if none of the union members results are returned.
+            push @codes, "${indent}v8SetReturnValueNull(${getCallbackInfo});";
+        }
         return join "\n", @codes;
     }
 
     if ($type eq "boolean") {
         return "${indent}v8SetReturnValueBool(${getCallbackInfo}, ${nativeValue});" if $isReturnValue;
         return "$indent$receiver v8Boolean($nativeValue, $getIsolate);";
     }
 
     if ($type eq "void") { # equivalent to v8Undefined()
         return "" if $isReturnValue;
@@ skipping 725 matching lines @@
         if ($parameter->type eq "SerializedScriptValue") {
             return 1;
         } elsif (IsIntegerType($parameter->type)) {
             return 1;
         }
     }
     return 0;
 }
 
 1;