Experimental parser: cleanup RegexParser

tools/lexer_generator/nfa_builder.py

 # Copyright 2013 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 277 matching lines @@
     return Term('CONTINUE', tree, depth)
 
   @staticmethod
   def unique_key(name):
     return Term('UNIQUE_KEY', name)
 
   @staticmethod
   def join_subtree(tree, subtree_name):
     return Term('JOIN', tree, subtree_name)
 
-  @staticmethod
-  def or_terms(terms):
-    if len(terms) == 1: return terms[0]
-    return Term('OR', *terms) if terms else Term.empty()
-
-  @staticmethod
-  def cat_terms(terms):
-    if len(terms) == 1: return terms[0]
-    return Term('CAT', *terms) if terms else Term.empty()
-
   __modifer_map = {
     '+': 'ONE_OR_MORE',
     '?': 'ZERO_OR_ONE',
     '*': 'ZERO_OR_MORE',
   }
 
   @staticmethod
   def apply_modifier(modifier, term):
     return Term(NfaBuilder.__modifer_map[modifier], term)
+
+  @staticmethod
+  def __flatten_terms(terms, name):
+    for term in terms:
+      assert isinstance(term, Term)
+      if not term:
+        continue
+      if term.name() == name:
+        for arg in term.args():
+          if arg:
+            yield arg
+      else:
+        yield term
+
+  @staticmethod
+  def __flatten_literals(terms):
+    literal = None
+    for term in terms:
+      assert isinstance(term, Term)
+      if not term:
+        continue
+      if term.name() == 'LITERAL':
+        if literal:
+          literal += term.args()[0]
+        else:
+          literal = term.args()[0]
+      else:
+        if literal:
+          yield Term('LITERAL', literal)
+          literal = None
+        if term:
+          yield term
+    if literal:
+      yield Term('LITERAL', literal)
+
+  @staticmethod
+  def or_terms(terms):
+    terms = list(NfaBuilder.__flatten_terms(terms, 'OR'))
+    assert terms
+    return terms[0] if len(terms) == 1 else Term('OR', *terms)
+
+  @staticmethod
+  def cat_terms(terms):
+    terms = NfaBuilder.__flatten_terms(terms, 'CAT')
+    terms = list(NfaBuilder.__flatten_literals(terms))
+    assert terms
+    return terms[0] if len(terms) == 1 else Term('CAT', *terms)