remoting/android/java/src/org/chromium/chromoting/Host.java - Issue 157013002: Pull HostListDirectoryGrabber out to a separate class.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/android/java/src/org/chromium/chromoting/Host.java

Issue 157013002: Pull HostListDirectoryGrabber out to a separate class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add Host class and address comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 package org.chromium.chromoting;

	6

	7 /** Class to represent a Host returned by {@link HostListLoader}. */

	8 public class Host {
	Sergey Ulanov 2014/02/13 19:36:07 Does the style guide allow struct-like classes lik Does the style guide allow struct-like classes like this? AFAIK it doesn't so you need to make th make the data fields private and add public methods to access them. Sergey Ulanov 2014/02/14 08:55:20 Call it HostInfo? Call it HostInfo? Lambros 2014/02/15 01:40:21 Done. Show quoted text On 2014/02/14 08:55:20, Sergey Ulanov wrote: > Call it HostInfo? Done.
	9 public String name;

	10 public String id;

	11 public String jabberId;

	12 public String publicKey;

	13 public boolean isOnline;

	14 }

OLD	NEW