Visual Studio generators for GN

tools/gn/visual_studio_writer.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[brettw, 2016/01/08 23:51:50]

The current copyright guidance has no "(c)".
(same in the other new file)

[Tomasz Moniuszko, 2016/01/21 10:50:03]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef TOOLS_GN_VISUAL_STUDIO_WRITER_H_
+#define TOOLS_GN_VISUAL_STUDIO_WRITER_H_
+
+#include <vector>
+
+#include "base/macros.h"
+
+class Builder;
+class BuildSettings;
+class Err;
+struct ProjectConfiguration;

[brettw, 2016/01/08 23:51:50]

I think this is too general a name to expose in the global namespace. I'd
actually make this an inner class inside VisualStudioWriter (can be private) and
then move the current WriteMsBuildProject into this class (doesn't need a
build_settings param then either).

[Tomasz Moniuszko, 2016/01/21 10:50:03]

Done. ProjectConfiguration members are now a part of VisualStudioWriter.

+class Target;
+
+class VisualStudioWriter {
+ public:
+  // On failure will populate |err| and return false.
+  static bool RunAndWriteFiles(const BuildSettings* build_settings,
+                               Builder* builder,
+                               Err* err);
+
+ private:
+  explicit VisualStudioWriter(const BuildSettings* build_settings);
+  ~VisualStudioWriter();
+
+  bool WriteProjectFile(const Target* target,
+                        const ProjectConfiguration& config,
+                        Err* err) const;
+  bool WriteSolutionFile(const std::vector<const Target*>& targets) const;
+
+  const BuildSettings* build_settings_;
+
+  DISALLOW_COPY_AND_ASSIGN(VisualStudioWriter);
+};
+
+#endif  // TOOLS_GN_VISUAL_STUDIO_WRITER_H_