Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: chrome/browser/sync/glue/shared_change_processor.cc

Issue 15701022: [Sync] Add support for sync Persistence Errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move bookmark change into separate patch Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/shared_change_processor.cc
diff --git a/chrome/browser/sync/glue/shared_change_processor.cc b/chrome/browser/sync/glue/shared_change_processor.cc
index 0dd0833df45a4f0c2c3a28a7c5a6b32daf32e838..abe7070867a8eb6ff0b41d037498adccda088034 100644
--- a/chrome/browser/sync/glue/shared_change_processor.cc
+++ b/chrome/browser/sync/glue/shared_change_processor.cc
@@ -95,7 +95,10 @@ syncer::SyncError SharedChangeProcessor::GetSyncData(
DCHECK(backend_loop_->BelongsToCurrentThread());
AutoLock lock(monitor_lock_);
if (disconnected_) {
- syncer::SyncError error(FROM_HERE, "Change processor disconnected.", type_);
+ syncer::SyncError error(FROM_HERE,
+ syncer::SyncError::DATATYPE_ERROR,
+ "Change processor disconnected.",
+ type_);
return error;
}
return generic_change_processor_->GetSyncDataForType(type_,
@@ -122,7 +125,10 @@ syncer::SyncError SharedChangeProcessor::ProcessSyncChanges(
if (disconnected_) {
// The DTC that disconnects us must ensure it posts a StopSyncing task.
// If we reach this, it means it just hasn't executed yet.
- syncer::SyncError error(FROM_HERE, "Change processor disconnected.", type_);
+ syncer::SyncError error(FROM_HERE,
+ syncer::SyncError::DATATYPE_ERROR,
+ "Change processor disconnected.",
+ type_);
return error;
}
return generic_change_processor_->ProcessSyncChanges(
@@ -173,7 +179,10 @@ syncer::SyncError SharedChangeProcessor::CreateAndUploadError(
if (!disconnected_) {
return error_handler_->CreateAndUploadError(location, message, type_);
} else {
- return syncer::SyncError(location, message, type_);
+ return syncer::SyncError(location,
+ syncer::SyncError::DATATYPE_ERROR,
+ message,
+ type_);
}
}

Powered by Google App Engine
This is Rietveld 408576698