Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2420)

Unified Diff: chrome/browser/sync/glue/model_association_manager.cc

Issue 15701022: [Sync] Add support for sync Persistence Errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/model_association_manager.cc
diff --git a/chrome/browser/sync/glue/model_association_manager.cc b/chrome/browser/sync/glue/model_association_manager.cc
index 4c68714f650f016db78373314e45019f91edf246..1b2be13f2e707be6f61e9f4268646f7a7048acea 100644
--- a/chrome/browser/sync/glue/model_association_manager.cc
+++ b/chrome/browser/sync/glue/model_association_manager.cc
@@ -307,11 +307,11 @@ bool ModelAssociationManager::GetControllersNeedingStart(
void ModelAssociationManager::AppendToFailedDatatypesAndLogError(
DataTypeController::StartResult result,
const syncer::SyncError& error) {
- failed_data_types_info_[error.type()] = error;
+ failed_data_types_info_[error.model_type()] = error;
LOG(ERROR) << "Failed to associate models for "
- << syncer::ModelTypeToString(error.type());
+ << syncer::ModelTypeToString(error.model_type());
UMA_HISTOGRAM_ENUMERATION("Sync.ConfigureFailed",
- ModelTypeToHistogramInt(error.type()),
+ ModelTypeToHistogramInt(error.model_type()),
syncer::MODEL_TYPE_COUNT);
}
@@ -382,7 +382,7 @@ void ModelAssociationManager::TypeStartCallback(
// Any other result requires reconfiguration. Pass it on through the callback.
LOG(ERROR) << "Failed to configure " << started_dtc->name();
DCHECK(local_merge_result.error().IsSet());
- DCHECK_EQ(started_dtc->type(), local_merge_result.error().type());
+ DCHECK_EQ(started_dtc->type(), local_merge_result.error().model_type());
DataTypeManager::ConfigureStatus configure_status =
DataTypeManager::ABORTED;
switch (start_result) {

Powered by Google App Engine
This is Rietveld 408576698