Only wait for CancelAllRequests done if the post task succeeds

SQLiteCursor could be destroyed in Java object's finalize method, and UI message loop might already shutdown, we need to check if the post task succeeds, then wait for callback.

BUG=239482
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203953

[Yaron, 2013-05-30 18:14:00]

lgtm

Not sure this is the cause but it's a good fix regardless.

https://codereview.chromium.org/15701011/diff/1/chrome/browser/history/androi...
File chrome/browser/history/android/sqlite_cursor.cc (right):

https://codereview.chromium.org/15701011/diff/1/chrome/browser/history/androi...
chrome/browser/history/android/sqlite_cursor.cc:161: &event)))
Please add {}

[michaelbai, 2013-05-30 18:33:56]

https://codereview.chromium.org/15701011/diff/1/chrome/browser/history/androi...
File chrome/browser/history/android/sqlite_cursor.cc (right):

https://codereview.chromium.org/15701011/diff/1/chrome/browser/history/androi...
chrome/browser/history/android/sqlite_cursor.cc:161: &event)))
On 2013/05/30 18:14:00, Yaron wrote:
> Please add {}

Done.

[sky, 2013-05-30 19:33:05]

https://codereview.chromium.org/15701011/diff/3/chrome/browser/history/androi...
File chrome/browser/history/android/sqlite_cursor.cc (right):

https://codereview.chromium.org/15701011/diff/3/chrome/browser/history/androi...
chrome/browser/history/android/sqlite_cursor.cc:159: if
(BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
From PostTask: " even if the task is posted, there's no guarantee that it will
run, since the target thread may already have a Quit message in its queue."

Does this code need to deal with the case of the UI messageloop not running or
in the process of shutting down?

[michaelbai, 2013-05-31 05:17:02]

https://codereview.chromium.org/15701011/diff/3/chrome/browser/history/androi...
File chrome/browser/history/android/sqlite_cursor.cc (right):

https://codereview.chromium.org/15701011/diff/3/chrome/browser/history/androi...
chrome/browser/history/android/sqlite_cursor.cc:159: if
(BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
In the case of UI message loop goes away, the whole process will be destroyed
soon, we don't care about deleting objects.
The SQLitCursor(this pointer) could be destroy from UI thread, so I removed the
wait event, put cleanup code into DestroyOnUIThread, and hope it get chance to
run, the Java code will not wait the cursor be destroyed any more.

I also modified unit test to reflect this change.

On 2013/05/30 19:33:05, sky wrote:
> From PostTask: " even if the task is posted, there's no guarantee that it will
> run, since the target thread may already have a Quit message in its queue."
> 
> Does this code need to deal with the case of the UI messageloop not running or
> in the process of shutting down?

[michaelbai, 2013-05-31 05:17:47]

PTAL

[michaelbai, 2013-06-03 16:54:10]

Sky@, would you like take another look?

[sky, 2013-06-03 17:48:25]

LGTM

https://codereview.chromium.org/15701011/diff/16001/chrome/browser/history/an...
File chrome/browser/history/android/sqlite_cursor.h (right):

https://codereview.chromium.org/15701011/diff/16001/chrome/browser/history/an...
chrome/browser/history/android/sqlite_cursor.h:139: void DestroyOnUIThread();
Add a comment.

https://codereview.chromium.org/15701011/diff/16001/chrome/browser/history/an...
chrome/browser/history/android/sqlite_cursor.h:141: 
nit: remove one of these newlines.

[michaelbai, 2013-06-03 22:25:37]

https://codereview.chromium.org/15701011/diff/16001/chrome/browser/history/an...
File chrome/browser/history/android/sqlite_cursor.h (right):

https://codereview.chromium.org/15701011/diff/16001/chrome/browser/history/an...
chrome/browser/history/android/sqlite_cursor.h:139: void DestroyOnUIThread();
On 2013/06/03 17:48:25, sky wrote:
> Add a comment.

Done.

https://codereview.chromium.org/15701011/diff/16001/chrome/browser/history/an...
chrome/browser/history/android/sqlite_cursor.h:141: 
On 2013/06/03 17:48:25, sky wrote:
> nit: remove one of these newlines.

Done.

[commit-bot: I haz the power, 2013-06-03 22:26:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/15701011/26001

[commit-bot: I haz the power, 2013-06-03 22:42:41]

Retried try job too often on mac for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2013-06-04 04:09:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/15701011/40001

[commit-bot: I haz the power, 2013-06-04 13:06:57]

Change committed as 203953