Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: content/browser/download/download_manager_impl.h

Issue 15701007: BrowserContext should simply own DownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased version of patch for win_rel Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_id_unittest.cc ('k') | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_manager_impl.h
diff --git a/content/browser/download/download_manager_impl.h b/content/browser/download/download_manager_impl.h
index bbdd0856ac6af37fa1459019aeb5e049c9659e90..7458433b4851a91b1405e11abc35458ac21b6e49 100644
--- a/content/browser/download/download_manager_impl.h
+++ b/content/browser/download/download_manager_impl.h
@@ -36,6 +36,7 @@ class CONTENT_EXPORT DownloadManagerImpl : public DownloadManager,
// Caller guarantees that |net_log| will remain valid
// for the lifetime of DownloadManagerImpl (until Shutdown() is called).
DownloadManagerImpl(net::NetLog* net_log, BrowserContext* browser_context);
+ virtual ~DownloadManagerImpl();
// Implementation functions (not part of the DownloadManager interface).
@@ -102,10 +103,6 @@ class CONTENT_EXPORT DownloadManagerImpl : public DownloadManager,
friend class DownloadManagerTest;
friend class DownloadTest;
- friend class base::RefCountedThreadSafe<DownloadManagerImpl>;
-
- virtual ~DownloadManagerImpl();
-
// Create a new active item based on the info. Separate from
// StartDownload() for testing.
DownloadItemImpl* CreateActiveItem(DownloadId id,
@@ -166,6 +163,8 @@ class CONTENT_EXPORT DownloadManagerImpl : public DownloadManager,
net::NetLog* net_log_;
+ base::WeakPtrFactory<DownloadManagerImpl> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(DownloadManagerImpl);
};
« no previous file with comments | « content/browser/download/download_id_unittest.cc ('k') | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698