chrome/browser/download/download_ui_controller_unittest.cc - Issue 15701007: BrowserContext should simply own DownloadManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 15701007: BrowserContext should simply own DownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased version of patch for win_rel Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_ui_controller_unittest.cc

diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc

index 17b7bcc7598bc40a04f5d2b6b49ef0e8a780f733..61691c4365eb4fa9d76ef1eb1a722a09f4a31ac8 100644

--- a/chrome/browser/download/download_ui_controller_unittest.cc

+++ b/chrome/browser/download/download_ui_controller_unittest.cc

@@ -69,7 +69,7 @@ class DownloadUIControllerTest : public testing::Test {

content::DownloadItem* received_item() { return received_item_; }

private:

- scoped_refptr<MockDownloadManager> manager_;

+ scoped_ptr<MockDownloadManager> manager_;

content::DownloadManager::Observer* manager_observer_;

content::DownloadItem::Observer* item_observer_;

content::DownloadItem* received_item_;

@@ -85,7 +85,7 @@ DownloadUIControllerTest::DownloadUIControllerTest()

}

void DownloadUIControllerTest::SetUp() {

- manager_ = new testing::StrictMock<MockDownloadManager>();

+ manager_.reset(new testing::StrictMock<MockDownloadManager>());

EXPECT_CALL(*manager_, AddObserver(_))

.WillOnce(SaveArg<0>(&manager_observer_));

EXPECT_CALL(*manager_, RemoveObserver(_))