chrome/browser/download/download_shelf_unittest.cc - Issue 15701007: BrowserContext should simply own DownloadManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf_unittest.cc

Issue 15701007: BrowserContext should simply own DownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased version of patch for win_rel Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_shelf_unittest.cc

diff --git a/chrome/browser/download/download_shelf_unittest.cc b/chrome/browser/download/download_shelf_unittest.cc

index 21ca39813ead1900252c1da97ddb8c4a73997495..3b53c849161a299e2b1389c7ad9b852937453626 100644

--- a/chrome/browser/download/download_shelf_unittest.cc

+++ b/chrome/browser/download/download_shelf_unittest.cc

@@ -43,7 +43,7 @@ class DownloadShelfTest : public testing::Test {

MessageLoopForUI message_loop_;

content::TestBrowserThread ui_thread_;

scoped_ptr<content::MockDownloadItem> download_item_;

- scoped_refptr<content::MockDownloadManager> download_manager_;

+ scoped_ptr<content::MockDownloadManager> download_manager_;

TestDownloadShelf shelf_;

};

@@ -63,7 +63,8 @@ DownloadShelfTest::DownloadShelfTest()

ON_CALL(*download_item_, ShouldOpenFileBasedOnExtension())

.WillByDefault(Return(false));

- download_manager_ = new ::testing::NiceMock<content::MockDownloadManager>();

+ download_manager_.reset(

+ new ::testing::NiceMock<content::MockDownloadManager>());

ON_CALL(*download_manager_, GetDownload(_))

.WillByDefault(Return(download_item_.get()));