Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 1570043004: Adds --skip-clear-data flag to android's test_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/instrumentation/test_runner.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/local/device/local_device_gtest_run.py
diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py
index ce73c43b8ee0f620a4c9f91bcf9d4416d47b2790..74335239fa56165204d3ef44fa6ceddc6b69300e 100644
--- a/build/android/pylib/local/device/local_device_gtest_run.py
+++ b/build/android/pylib/local/device/local_device_gtest_run.py
@@ -344,9 +344,7 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):
if self._test_instance.app_files:
self._delegate.PullAppFiles(device, self._test_instance.app_files,
self._test_instance.app_file_dir)
- # Clearing data when using incremental install wipes out cached optimized
- # dex files (and shouldn't be necessary by tests anyways).
- if not self._env.incremental_install:
+ if not self._test_instance.skip_clear_data:
jbudorick 2016/02/03 14:38:27 Why are we adding this in addition to --incrementa
agrieve 2016/02/03 16:34:32 I'm envisioning adding a --fast-local-dev (or bett
self._delegate.Clear(device)
# Parse the output.
« no previous file with comments | « build/android/pylib/instrumentation/test_runner.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698