content/public/browser/web_contents_observer.h - Issue 1570043002: Implement MediaSession on top of the WebMediaPlayerDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_observer.h

Issue 1570043002: Implement MediaSession on top of the WebMediaPlayerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_session

Patch Set: Reorder. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/content_tests.gypi ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents_observer.h

diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h

index 3d770b73791e7f2c108a1707830aa750911e9a8a..b607d71556aa1840b2281feab2e445781f82a801 100644

--- a/content/public/browser/web_contents_observer.h

+++ b/content/public/browser/web_contents_observer.h

@@ -435,7 +435,7 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,

// and subsequently within a WebContents. MediaStartedPlaying() will always

// be followed by MediaStoppedPlaying() after player teardown. Observers must

// release all stored copies of |id| when MediaStoppedPlaying() is received.

- using MediaPlayerId = std::pair<RenderFrameHost*, int64_t>;

+ using MediaPlayerId = std::pair<RenderFrameHost*, int>;

virtual void MediaStartedPlaying(const MediaPlayerId& id) {}

virtual void MediaStoppedPlaying(const MediaPlayerId& id) {}