chrome/browser/media/android/remote/remote_media_player_manager.cc - Issue 1570043002: Implement MediaSession on top of the WebMediaPlayerDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/android/remote/remote_media_player_manager.cc

Issue 1570043002: Implement MediaSession on top of the WebMediaPlayerDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_session

Patch Set: Comments. Fix test? Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/android/remote/remote_media_player_manager.h ('k') | content/browser/media/android/browser_media_player_manager.h » ('j') | content/browser/media/android/browser_media_player_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/android/remote/remote_media_player_manager.cc

diff --git a/chrome/browser/media/android/remote/remote_media_player_manager.cc b/chrome/browser/media/android/remote/remote_media_player_manager.cc

index 375e7e07528e490abe8d991ea7559d27a039404b..a35ccc772b588b9e6d41a06b60f1ab9e9400f89f 100644

--- a/chrome/browser/media/android/remote/remote_media_player_manager.cc

+++ b/chrome/browser/media/android/remote/remote_media_player_manager.cc

@@ -139,18 +139,6 @@ RemoteMediaPlayerBridge* RemoteMediaPlayerManager::CreateRemoteMediaPlayer(

return player;

}

-// OnSuspend and OnResume are called when the local player loses or gains

-// audio focus. If we are playing remotely then ignore these.

-void RemoteMediaPlayerManager::OnSuspend(int player_id) {

- if (!IsPlayingRemotely(player_id))

- BrowserMediaPlayerManager::OnSuspend(player_id);

-void RemoteMediaPlayerManager::OnResume(int player_id) {

- if (!IsPlayingRemotely(player_id))

- BrowserMediaPlayerManager::OnResume(player_id);

void RemoteMediaPlayerManager::SwapCurrentPlayer(int player_id) {

// Find the remote player

auto it = GetAlternativePlayer(player_id);