Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 157001: Modify OLA to use window size in seconds instead of bytes. (Closed)

Created:
11 years, 5 months ago by kylep
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, fbarchard
Visibility:
Public.

Description

Modify OLA to use window size in seconds instead of bytes. BUG=16011 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20416

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -19 lines) Patch
M media/filters/audio_renderer_algorithm_base.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M media/filters/audio_renderer_algorithm_base.cc View 1 2 3 chunks +13 lines, -1 line 0 comments Download
M media/filters/audio_renderer_algorithm_ola.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M media/filters/audio_renderer_algorithm_ola.cc View 1 2 4 chunks +23 lines, -11 lines 0 comments Download
M media/tools/wav_ola_test.cc View 1 2 5 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kylep
Trybots are failing because they haven't picked up my previous patch yet. Please review regardless; ...
11 years, 5 months ago (2009-07-10 01:17:33 UTC) #1
scherkus (not reviewing)
Can you add BUG=16011 to the changelist description?
11 years, 5 months ago (2009-07-10 01:23:50 UTC) #2
scherkus (not reviewing)
few tiny nits, and don't forget to attach the BUG= number http://codereview.chromium.org/157001/diff/1/5 File media/filters/audio_renderer_algorithm_ola.cc (right): ...
11 years, 5 months ago (2009-07-10 01:30:19 UTC) #3
kylep
Frank - I think this patch makes it sound better even on the inputs I ...
11 years, 5 months ago (2009-07-10 18:06:07 UTC) #4
scherkus (not reviewing)
11 years, 5 months ago (2009-07-10 18:41:45 UTC) #5
awesome!

lgtm!

http://codereview.chromium.org/157001/diff/3003/3006
File media/filters/audio_renderer_algorithm_base.cc (right):

http://codereview.chromium.org/157001/diff/3003/3006#newcode37
Line 37: DCHECK(callback);
nit: move this DCHECK to end of your DCHECKs so that all the sample_bits ones
are together

Powered by Google App Engine
This is Rietveld 408576698