Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 15700007: Refacturing BuildEmitDeepCopy. (Closed)

Created:
7 years, 7 months ago by Hannes Payer (out of office)
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refacturing BuildEmitDeepCopy. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14845

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -137 lines) Patch
M src/code-stubs-hydrogen.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.h View 1 2 chunks +31 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 1 7 chunks +171 lines, -128 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hannes Payer (out of office)
This is an effort to improve readability of BuildEmitDeepCopy while keeping the recursive nature of ...
7 years, 7 months ago (2013-05-27 11:28:22 UTC) #1
mvstanton
Hi Hannes, lgtm. I think your suggestion to keep BuildEmitInObjectProperties() as one method is a ...
7 years, 6 months ago (2013-05-28 07:29:56 UTC) #2
Hannes Payer (out of office)
7 years, 6 months ago (2013-05-28 10:44:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14845 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698