Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1569983004: Image filters: fix srcRect computation for FETile. (Closed)

Created:
4 years, 11 months ago by Stephen White
Modified:
4 years, 11 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, danakj, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Image filters: fix srcRect computation for FETile. For FETile's srcRect, use the computed filter primitive subregion, rather than the filterRegion with effect bounds applied. This will allow some upcoming optimizations in Skia. BUG=569950 Committed: https://crrev.com/bd9c806a5784da8805fd2b90eec8d15ad1057b3f Cr-Commit-Position: refs/heads/master@{#368429}

Patch Set 1 #

Patch Set 2 : Add a #define to suppress the Skia optimization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M skia/config/SkUserConfig.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETile.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Stephen White
junov@: PTAL. Thanks!
4 years, 11 months ago (2016-01-08 18:41:33 UTC) #3
Justin Novosad
On 2016/01/08 18:41:33, Stephen White wrote: > junov@: PTAL. Thanks! lgtm
4 years, 11 months ago (2016-01-08 19:16:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569983004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569983004/20001
4 years, 11 months ago (2016-01-08 19:17:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 20:36:59 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 20:37:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd9c806a5784da8805fd2b90eec8d15ad1057b3f
Cr-Commit-Position: refs/heads/master@{#368429}

Powered by Google App Engine
This is Rietveld 408576698