Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1569963002: Make the Permission Bubble Manager use a correct same-origin check. (Closed)

Created:
4 years, 11 months ago by palmer
Modified:
4 years, 11 months ago
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the Permission Bubble Manager use a correct same-origin check. GURL::GetOrigin does not do the right thing for all types of URLs. BUG=573317 Committed: https://crrev.com/58cb65370efa360e924ca222af05c3bef09e168c Cr-Commit-Position: refs/heads/master@{#368641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/website_settings/permission_bubble_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
palmer
PTAL. Thanks!
4 years, 11 months ago (2016-01-07 20:49:27 UTC) #2
Mike West
On 2016/01/07 at 20:49:27, palmer wrote: > PTAL. Thanks! LGTM, FWIW.
4 years, 11 months ago (2016-01-08 08:46:55 UTC) #3
felt
lgtm
4 years, 11 months ago (2016-01-08 15:13:58 UTC) #4
markusheintz_
LGTM
4 years, 11 months ago (2016-01-11 17:13:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569963002/1
4 years, 11 months ago (2016-01-11 18:40:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 19:46:53 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 19:48:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58cb65370efa360e924ca222af05c3bef09e168c
Cr-Commit-Position: refs/heads/master@{#368641}

Powered by Google App Engine
This is Rietveld 408576698