Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated dominickn's comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index c11b4cb121197f0d7ab9d69e51142e5c318522aa..9d43dd39fa3b612a51b1989511de5ed8947ae1ae 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -39,6 +39,10 @@ class AppBannerManager : public content::WebContentsObserver,
// Returns whether or not the URLs match for everything except for the ref.
static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);
+ void RequestAppBanner(content::RenderFrameHost* render_frame_host,
gone 2016/01/19 18:35:00 nit: Add a comment here?
horo 2016/01/20 02:26:34 Done.
+ const GURL& validated_url,
+ bool is_debug_mode);
+
AppBannerManager();
~AppBannerManager() override;
@@ -49,7 +53,8 @@ class AppBannerManager : public content::WebContentsObserver,
// Creates an AppBannerDataFetcher, which constructs an app banner.
virtual AppBannerDataFetcher* CreateAppBannerDataFetcher(
- base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate) = 0;
+ base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
+ bool is_debug_mode) = 0;
// Return whether the AppBannerDataFetcher is active.
bool IsFetcherActive();
@@ -68,7 +73,8 @@ class AppBannerManager : public content::WebContentsObserver,
// AppBannerDataFetcher::Delegate overrides.
bool HandleNonWebApp(const std::string& platform,
const GURL& url,
- const std::string& id) override;
+ const std::string& id,
+ bool is_debug_mode) override;
// Cancels an active DataFetcher, stopping its banners from appearing.
void CancelActiveFetcher();

Powered by Google App Engine
This is Rietveld 408576698