chrome/browser/android/tab_android.cc - Issue 1569893003: Add "Request app banner" context menu in DevTools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.cc

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated dominickn's comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_android.cc

diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc

index 80157cef7d3c36fc67944ffc230da12c4b826458..1e40729d6e2c405a2ded1bb7c16a6e0bdfc04d25 100644

--- a/chrome/browser/android/tab_android.cc

+++ b/chrome/browser/android/tab_android.cc

@@ -275,6 +275,11 @@ void TabAndroid::SwapTabContents(content::WebContents* old_contents,

did_finish_load);

}

+bool TabAndroid::RequestAppBanner(content::WebContents* web_contents) {

+ JNIEnv* env = base::android::AttachCurrentThread();

+ return Java_Tab_requestAppBanner(env, weak_java_tab_.get(env).obj());

void TabAndroid::DefaultSearchProviderChanged(

bool google_base_url_domain_changed) {

// TODO(kmadhusu): Move this function definition to a common place and update