chrome/browser/ui/browser.cc - Issue 1569893003: Add "Request app banner" context menu in DevTools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated dominickn's comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_debug_log.cc ('K') | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/tab_contents/core_tab_helper_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 717381dfc44ad34716308ce06f5a11385705195a..4fef9c19430696effebf56eaace8b3a12c6fb72a 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -36,6 +36,7 @@

#include "chrome/browser/background/background_contents.h"

#include "chrome/browser/background/background_contents_service.h"

#include "chrome/browser/background/background_contents_service_factory.h"

+#include "chrome/browser/banners/app_banner_manager_desktop.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/browser_shutdown.h"

#include "chrome/browser/character_encoding.h"

@@ -181,6 +182,7 @@

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/plugin_service.h"

+#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/render_widget_host.h"

@@ -1978,6 +1980,17 @@ bool Browser::CanSaveContents(content::WebContents* web_contents) const {

return chrome::CanSavePage(this);

}

+bool Browser::RequestAppBanner(content::WebContents* web_contents) {

+ content::RenderFrameHost* frame = web_contents->GetMainFrame();

+ banners::AppBannerManagerDesktop* manager =

+ banners::AppBannerManagerDesktop::FromWebContents(web_contents);

+ if (manager) {

+ manager->RequestAppBanner(frame, frame->GetLastCommittedURL(), true);

+ return true;

dominickn 2016/01/18 23:20:41 Nit: like previously, call this as manager->Reques

horo 2016/01/19 01:45:43 Done.

+ }

+ return false;

///////////////////////////////////////////////////////////////////////////////

// Browser, SearchEngineTabHelperDelegate implementation:

« chrome/browser/banners/app_banner_debug_log.cc ('K') | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/tab_contents/core_tab_helper_delegate.h » ('j') | no next file with comments »