Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: chrome/browser/banners/app_banner_debug_log.cc

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android support Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_debug_log.cc
diff --git a/chrome/browser/banners/app_banner_debug_log.cc b/chrome/browser/banners/app_banner_debug_log.cc
index e1b06f91b5a42ee79b917a32db5ae27d3406a3d8..4d9a0cded747dee07f655bd9eb59cfc9175be698 100644
--- a/chrome/browser/banners/app_banner_debug_log.cc
+++ b/chrome/browser/banners/app_banner_debug_log.cc
@@ -44,15 +44,19 @@ const char kIgnoredIdsDoNotMatch[] =
"manifest, but they do not match";
void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
- const std::string& message) {
- OutputDeveloperDebugMessage(web_contents, "not shown: " + message);
+ const std::string& message,
+ bool is_debug_mode) {
+ OutputDeveloperDebugMessage(web_contents, "not shown: " + message,
+ is_debug_mode);
}
void OutputDeveloperDebugMessage(content::WebContents* web_contents,
- const std::string& message) {
+ const std::string& message,
+ bool is_debug_mode) {
std::string log_message = "App banner " + message;
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kBypassAppBannerEngagementChecks) &&
+ if ((is_debug_mode ||
+ base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kBypassAppBannerEngagementChecks)) &&
web_contents) {
web_contents->GetMainFrame()->AddMessageToConsole(
content::CONSOLE_MESSAGE_LEVEL_DEBUG, log_message);

Powered by Google App Engine
This is Rietveld 408576698