Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4101)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_unittest.cc

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android support Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher_unittest.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc
index 3b68086d4912238f6ee11abb69a89a93ed16820b..1dfe9d2e174050ead55916fb46c23020182ad6cf 100644
--- a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc
@@ -36,7 +36,8 @@ class AppBannerDataFetcherUnitTest : public testing::Test {
// The second argument is the web_contents pointer, which is used for
// developer debug logging to the console. The logging is skipped inside the
// method if a null web_contents pointer is provided, so this is safe.
dominickn 2016/01/17 23:20:18 Nit: add a comment about the third argument here.
horo 2016/01/18 06:28:56 Done.
- return AppBannerDataFetcher::IsManifestValidForWebApp(manifest, nullptr);
+ return AppBannerDataFetcher::IsManifestValidForWebApp(manifest, nullptr,
+ false);
}
};

Powered by Google App Engine
This is Rietveld 408576698