Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5093)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on https://codereview.chromium.org/1571633002/ Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index e984f2de63ec6015b6c1e87f305da057e163a619..4abb760719f92740806ccdf01dc2bd8e79c3e513 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -70,9 +70,10 @@ void AppBannerManager::DidNavigateMainFrame(
last_transition_type_ = params.transition;
}
-void AppBannerManager::DidFinishLoad(
+void AppBannerManager::TriggerAppBannerFetch(
content::RenderFrameHost* render_frame_host,
- const GURL& validated_url) {
+ const GURL& validated_url,
+ bool is_debug_mode) {
if (render_frame_host->GetParent())
return;
@@ -85,15 +86,23 @@ void AppBannerManager::DidFinishLoad(
// URL is invalid.
if (!content::IsOriginSecure(validated_url) &&
!gDisableSecureCheckForTesting) {
- OutputDeveloperNotShownMessage(web_contents(), kNotServedFromSecureOrigin);
+ OutputDeveloperNotShownMessage(web_contents(), kNotServedFromSecureOrigin,
+ is_debug_mode);
return;
}
// Kick off the data retrieval pipeline.
- data_fetcher_ = CreateAppBannerDataFetcher(weak_factory_.GetWeakPtr());
+ data_fetcher_ =
+ CreateAppBannerDataFetcher(weak_factory_.GetWeakPtr(), is_debug_mode);
data_fetcher_->Start(validated_url, last_transition_type_);
}
+void AppBannerManager::DidFinishLoad(
+ content::RenderFrameHost* render_frame_host,
+ const GURL& validated_url) {
+ TriggerAppBannerFetch(render_frame_host, validated_url, false);
+}
+
bool AppBannerManager::HandleNonWebApp(const std::string& platform,
const GURL& url,
const std::string& id) {

Powered by Google App Engine
This is Rietveld 408576698