Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on https://codereview.chromium.org/1571633002/ Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index 24236a133527aef496855f8aa498cb0051ff45bd..467be394305a541d51d78d7c69da2f803f16e3a7 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -59,7 +59,8 @@ class AppBannerDataFetcher
AppBannerDataFetcher(content::WebContents* web_contents,
base::WeakPtr<Delegate> weak_delegate,
int ideal_icon_size_in_dp,
- int minimum_icon_size_in_dp);
+ int minimum_icon_size_in_dp,
+ bool is_debug_mode);
// Begins creating a banner for the URL being displayed by the Delegate's
// WebContents.
@@ -170,7 +171,8 @@ class AppBannerDataFetcher
// Returns whether the given Manifest is following the requirements to show
// a web app banner.
static bool IsManifestValidForWebApp(const content::Manifest& manifest,
- content::WebContents* web_contents);
+ content::WebContents* web_contents,
+ bool is_debug_mode);
const base::WeakPtr<Delegate> weak_delegate_;
const int ideal_icon_size_in_dp_;
@@ -187,6 +189,7 @@ class AppBannerDataFetcher
GURL validated_url_;
base::string16 app_title_;
content::Manifest web_app_data_;
+ const bool is_debug_mode_;
friend class AppBannerDataFetcherUnitTest;
friend class base::RefCounted<AppBannerDataFetcher>;

Powered by Google App Engine
This is Rietveld 408576698