Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4650)

Unified Diff: chrome/browser/banners/app_banner_debug_log.cc

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated pfeldman's comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_debug_log.cc
diff --git a/chrome/browser/banners/app_banner_debug_log.cc b/chrome/browser/banners/app_banner_debug_log.cc
index e1b06f91b5a42ee79b917a32db5ae27d3406a3d8..99e26f7be00e6862030316bac2a39276d153fc16 100644
--- a/chrome/browser/banners/app_banner_debug_log.cc
+++ b/chrome/browser/banners/app_banner_debug_log.cc
@@ -4,8 +4,6 @@
#include "chrome/browser/banners/app_banner_debug_log.h"
-#include "base/command_line.h"
-#include "chrome/common/chrome_switches.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
@@ -33,6 +31,7 @@ const char kManifestMissingNameOrShortName[] =
const char kManifestMissingSuitableIcon[] =
"manifest does not contain a suitable icon - PNG format of at least "
"144x144px is required, and the sizes attribute must be set";
+const char kNotLoadedInMainFrame[] = "page not loaded in the main frame";
const char kNotServedFromSecureOrigin[] =
"page not served from a secure origin";
// The leading space is intentional as another string is prepended.
@@ -44,19 +43,19 @@ const char kIgnoredIdsDoNotMatch[] =
"manifest, but they do not match";
void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
- const std::string& message) {
- OutputDeveloperDebugMessage(web_contents, "not shown: " + message);
+ const std::string& message,
+ bool is_debug_mode) {
+ OutputDeveloperDebugMessage(web_contents, "not shown: " + message,
+ is_debug_mode);
}
void OutputDeveloperDebugMessage(content::WebContents* web_contents,
- const std::string& message) {
- std::string log_message = "App banner " + message;
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kBypassAppBannerEngagementChecks) &&
- web_contents) {
- web_contents->GetMainFrame()->AddMessageToConsole(
- content::CONSOLE_MESSAGE_LEVEL_DEBUG, log_message);
- }
+ const std::string& message,
+ bool is_debug_mode) {
+ if (!is_debug_mode || !web_contents)
+ return;
+ web_contents->GetMainFrame()->AddMessageToConsole(
+ content::CONSOLE_MESSAGE_LEVEL_DEBUG, "App banner " + message);
}
} // namespace banners
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698