Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.h

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated pfeldman's comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.h
diff --git a/chrome/browser/android/banners/app_banner_manager_android.h b/chrome/browser/android/banners/app_banner_manager_android.h
index 1d609072140e8b27e55eaf1212b7e69e270f6496..69a2b785195c1e6845f9e5ec31a967fed7883356 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.h
+++ b/chrome/browser/android/banners/app_banner_manager_android.h
@@ -52,19 +52,27 @@ class AppBannerManagerAndroid : public AppBannerManager {
const base::android::JavaParamRef<jstring>& japp_package,
const base::android::JavaParamRef<jstring>& jicon_url);
+ // Requests the app banner. This method is called from the DevTools.
+ void RequestAppBanner(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& jobj);
+
protected:
AppBannerDataFetcher* CreateAppBannerDataFetcher(
- base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate) override;
+ base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
+ bool is_debug_mode) override;
private:
// AppBannerDataFetcher::Delegate overrides.
bool HandleNonWebApp(const std::string& platform,
const GURL& url,
- const std::string& id) override;
+ const std::string& id,
+ bool is_debug_mode) override;
- bool CheckPlatformAndId(const std::string& platform, const std::string& id);
+ bool CheckPlatformAndId(const std::string& platform,
+ const std::string& id,
+ bool is_debug_mode);
- bool CheckFetcherMatchesContents();
+ bool CheckFetcherMatchesContents(bool is_debug_mode);
std::string ExtractQueryValueForName(const GURL& url,
const std::string& name);

Powered by Google App Engine
This is Rietveld 408576698