chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 1569893003: Add "Request app banner" context menu in DevTools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated pfeldman's comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index 88b341a7e36dae22cde95004e984dcd76a2eabda..db51e95fa7ed3a34d72bde5a94b6dcef3801fef9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -2223,6 +2223,13 @@ public final class Tab implements ViewGroup.OnHierarchyChangeListener,

}

+ /** Requests the app banner. This method is called from the DevTools. */

+ protected boolean requestAppBanner() {

+ if (mAppBannerManager == null) return false;

+ mAppBannerManager.requestAppBanner();

+ return true;

+ }

@CalledByNative

private void clearNativePtr() {

assert mNativeTabAndroid != 0;