Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated dfalcantara's comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
index 957b5baea9d01e8a6a2c06d234e91fb57f678dd4..dd6ac3e63d440d626b3c07c5e612aca4dd6cbd50 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
@@ -550,7 +550,10 @@ WebInspector.NavigatorView.prototype = {
contextMenu.show();
},
-
+ _requestAppBanner: function(agent)
+ {
+ agent.requestAppBanner();
pfeldman 2016/01/20 04:30:17 poor indentation.
horo 2016/01/20 11:01:41 Removed
+ },
/**
* @param {!Event} event
* @param {!WebInspector.NavigatorFolderTreeNode} node
@@ -561,7 +564,12 @@ WebInspector.NavigatorView.prototype = {
var project = node._project;
var contextMenu = new WebInspector.ContextMenu(event);
-
+ if (node.parent.isRoot()) {
pfeldman 2016/01/20 04:30:17 Ditto. This context menu is not discoverable. And
horo 2016/01/20 11:01:41 Reverted NavigatorView.js and changed ScreencastAp
+ var target = WebInspector.NetworkProject.targetForProject(project);
+ if (target.isPage()) {
+ contextMenu.appendItem(WebInspector.UIString.capitalize("Request app banner"), this._requestAppBanner.bind(this, target.pageAgent()));
+ }
+ }
if (project && project.type() === WebInspector.projectTypes.FileSystem) {
contextMenu.appendItem(WebInspector.UIString.capitalize("Refresh"), this._handleContextMenuRefresh.bind(this, project, path));
if (node instanceof WebInspector.NavigatorFolderTreeNode) {

Powered by Google App Engine
This is Rietveld 408576698