Add "Request app banner" context menu in DevTools

chrome/browser/banners/app_banner_debug_log.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_debug_log.h"
 
 #include "base/command_line.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 15 matching lines @@
 const char kBannerAlreadyAdded[] =
     "site requesting the banner has already been added";
 const char kUserNavigatedBeforeBannerShown[] =
     "the user navigated before the banner could be shown";
 const char kStartURLNotValid[] = "start URL in manifest is not valid";
 const char kManifestMissingNameOrShortName[] =
     "one of manifest name or short name must be specified";
 const char kManifestMissingSuitableIcon[] =
     "manifest does not contain a suitable icon - PNG format of at least "
     "144x144px is required, and the sizes attribute must be set";
+const char kNotLoadedInMainFrame[] = "page not loaded in the main frame";
 const char kNotServedFromSecureOrigin[] =
     "page not served from a secure origin";
 // The leading space is intentional as another string is prepended.
 const char kIgnoredNotSupportedOnAndroid[] =
     " application ignored: not supported on Android";
 const char kIgnoredNoId[] = "play application ignored: no id provided";
 const char kIgnoredIdsDoNotMatch[] =
     "play application ignored: app URL and id fields were specified in the "
     "manifest, but they do not match";
 
 void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
-                                    const std::string& message) {
-  OutputDeveloperDebugMessage(web_contents, "not shown: " + message);
+                                    const std::string& message,
+                                    bool is_debug_mode) {
+  OutputDeveloperDebugMessage(web_contents, "not shown: " + message,
+                              is_debug_mode);
 }
 
 void OutputDeveloperDebugMessage(content::WebContents* web_contents,
-                                 const std::string& message) {
+                                 const std::string& message,
+                                 bool is_debug_mode) {
   std::string log_message = "App banner " + message;
-  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kBypassAppBannerEngagementChecks) &&
+  if ((is_debug_mode ||
+       base::CommandLine::ForCurrentProcess()->HasSwitch(
+           switches::kBypassAppBannerEngagementChecks)) &&

[dominickn, 2016/01/18 23:20:41]

With is_debug_mode incorporating the CommandLine check in the
AppBannerDataFetcher constructor you can remove the command line check in here,
i.e. just do if (is_debug_mode && web_contents).

[horo, 2016/01/19 01:45:43]

Done.

       web_contents) {
     web_contents->GetMainFrame()->AddMessageToConsole(
         content::CONSOLE_MESSAGE_LEVEL_DEBUG, log_message);
   }
 }
 
 }  // namespace banners