Add "Request app banner" context menu in DevTools

chrome/browser/banners/app_banner_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_manager.h"
 
 #include "chrome/browser/banners/app_banner_data_fetcher.h"
 #include "chrome/browser/banners/app_banner_debug_log.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "content/public/browser/navigation_details.h"
@@ skipping 52 matching lines @@
 bool AppBannerManager::IsFetcherActive() {
   return data_fetcher_ != nullptr && data_fetcher_->is_active();
 }
 
 void AppBannerManager::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
   last_transition_type_ = params.transition;
 }
 
-void AppBannerManager::DidFinishLoad(
+void AppBannerManager::TriggerAppBannerFetch(
     content::RenderFrameHost* render_frame_host,

[dominickn, 2016/01/17 23:20:19]

I dislike how render_frame_host is passed in here, but I suppose it *is*
possible for a developer to try putting in an app banner in a subframe. Perhaps
you could add an additional call to OutputDeveloperNotShownMessage when an app
banner is created and render_frame_host->GetParent() is not null?

Nit: I prefer the name "RequestAppBanner" for this method; banners themselves
don't need to be fetched from anywhere, but data for them does.

[horo, 2016/01/18 06:28:56]

Done.

-    const GURL& validated_url) {
+    const GURL& validated_url,
+    bool is_debug_mode) {
   if (render_frame_host->GetParent())
     return;
 
   if (data_fetcher_.get() && data_fetcher_->is_active() &&
-      URLsAreForTheSamePage(data_fetcher_->validated_url(), validated_url)) {
+      URLsAreForTheSamePage(data_fetcher_->validated_url(), validated_url) &&
+      !is_debug_mode) {
     return;
   }
 
   // A secure origin is required to show banners, so exit early if we see the
   // URL is invalid.
   if (!content::IsOriginSecure(validated_url) &&
       !gDisableSecureCheckForTesting) {
-    OutputDeveloperNotShownMessage(web_contents(), kNotServedFromSecureOrigin);
+    OutputDeveloperNotShownMessage(web_contents(), kNotServedFromSecureOrigin,
+                                   is_debug_mode);
     return;
   }
 
   // Kick off the data retrieval pipeline.
-  data_fetcher_ = CreateAppBannerDataFetcher(weak_factory_.GetWeakPtr());
+  data_fetcher_ =
+      CreateAppBannerDataFetcher(weak_factory_.GetWeakPtr(), is_debug_mode);
   data_fetcher_->Start(validated_url, last_transition_type_);
 }
 
+void AppBannerManager::DidFinishLoad(
+    content::RenderFrameHost* render_frame_host,
+    const GURL& validated_url) {
+  TriggerAppBannerFetch(render_frame_host, validated_url, false);

[dominickn, 2016/01/17 23:20:18]

Nit: add a comment explaining argument 3.

[horo, 2016/01/18 06:28:56]

Done.

+}
+
 bool AppBannerManager::HandleNonWebApp(const std::string& platform,
                                        const GURL& url,
-                                       const std::string& id) {
+                                       const std::string& id,
+                                       bool is_debug_mode) {
   return false;
 }
 
 void AppBannerManager::CancelActiveFetcher() {
   if (data_fetcher_ != nullptr) {
     data_fetcher_->Cancel();
     data_fetcher_ = nullptr;
   }
 }
 
 }  // namespace banners