Add "Request app banner" context menu in DevTools

chrome/browser/banners/app_banner_data_fetcher.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_DATA_FETCHER_H_
 #define CHROME_BROWSER_BANNERS_APP_BANNER_DATA_FETCHER_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 31 matching lines @@
                                         bool will_show) = 0;
     virtual void OnFetcherDestroyed(AppBannerDataFetcher* fetcher) = 0;
   };
 
   class Delegate {
    public:
     // Called to handle a non-web app. Returns |true| if the non-web app can be
     // handled, and the fetcher needs to remain active and wait for a callback.
     virtual bool HandleNonWebApp(const std::string& platform,
                                  const GURL& url,
-                                 const std::string& id) = 0;
+                                 const std::string& id,
+                                 bool is_debug_mode) = 0;
   };
 
   // Returns the current time.
   static base::Time GetCurrentTime();
 
   // Fast-forwards the current time for testing.
   static void SetTimeDeltaForTesting(int days);
 
   AppBannerDataFetcher(content::WebContents* web_contents,
                        base::WeakPtr<Delegate> weak_delegate,
                        int ideal_icon_size_in_dp,
-                       int minimum_icon_size_in_dp);
+                       int minimum_icon_size_in_dp,
+                       bool is_debug_mode);
 
   // Begins creating a banner for the URL being displayed by the Delegate's
   // WebContents.
   void Start(const GURL& validated_url, ui::PageTransition transition_type);
 
   // Stops the pipeline when any asynchronous calls return.
   void Cancel();
 
   // Replaces the WebContents that is being observed.
   void ReplaceWebContents(content::WebContents* web_contents);
@@ skipping 13 matching lines @@
   // Returns whether the page has validly requested that the banner be shown
   // by calling prompt() on the beforeinstallprompt Javascript event.
   bool page_requested_prompt() { return page_requested_prompt_; }
 
   // Returns the type of transition which triggered this fetch.
   ui::PageTransition transition_type() { return transition_type_; }
 
   // Returns the URL that kicked off the banner data retrieval.
   const GURL& validated_url() { return validated_url_; }
 
+  // Returns whether it was created by the user action in DevTools.
+  bool is_debug_mode() const { return is_debug_mode_; }

[dominickn, 2016/01/17 23:20:18]

Nit: after reordering, please place this following page_requested_prompt()

[horo, 2016/01/18 06:28:56]

Done.

+
   // WebContentsObserver overrides.
   void WebContentsDestroyed() override;
   void DidNavigateMainFrame(
       const content::LoadCommittedDetails& details,
       const content::FrameNavigateParams& params) override;
   bool OnMessageReceived(const IPC::Message& message,
                          content::RenderFrameHost* render_frame_host) override;
 
  protected:
   ~AppBannerDataFetcher() override;
@@ skipping 57 matching lines @@
   // Returns whether the banner should be shown.
   bool CheckIfShouldShowBanner();
 
   // Returns whether the fetcher is active and web contents have not been
   // closed.
   bool CheckFetcherIsStillAlive(content::WebContents* web_contents);
 
   // Returns whether the given Manifest is following the requirements to show
   // a web app banner.
   static bool IsManifestValidForWebApp(const content::Manifest& manifest,
-                                       content::WebContents* web_contents);
+                                       content::WebContents* web_contents,
+                                       bool is_debug_mode);
 
   const base::WeakPtr<Delegate> weak_delegate_;
   const int ideal_icon_size_in_dp_;
   const int minimum_icon_size_in_dp_;
   base::ObserverList<Observer> observer_list_;
   bool is_active_;
   bool was_canceled_by_page_;
   bool page_requested_prompt_;
   ui::PageTransition transition_type_;
   int event_request_id_;
   scoped_ptr<SkBitmap> app_icon_;
   std::string referrer_;
 
   GURL validated_url_;
   base::string16 app_title_;
   content::Manifest web_app_data_;
+  const bool is_debug_mode_;

[dominickn, 2016/01/17 23:20:18]

Nit: please put this below page_requested_prompt so that the 4 bools are
together.

[horo, 2016/01/18 06:28:56]

Done.

 
   friend struct content::BrowserThread::DeleteOnThread<
       content::BrowserThread::UI>;
   friend class base::DeleteHelper<AppBannerDataFetcher>;
   friend class AppBannerDataFetcherUnitTest;
   friend class base::RefCounted<AppBannerDataFetcher>;
   DISALLOW_COPY_AND_ASSIGN(AppBannerDataFetcher);
 };
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_BANNERS_APP_BANNER_DATA_FETCHER_H_