Add "Request app banner" context menu in DevTools

chrome/browser/devtools/chrome_devtools_manager_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/chrome_devtools_manager_delegate.h"
 
 #include "build/build_config.h"
+#include "chrome/browser/banners/app_banner_manager_desktop.h"
 #include "chrome/browser/devtools/devtools_network_protocol_handler.h"
+#include "chrome/browser/devtools/devtools_protocol_constants.h"
+#include "content/public/browser/render_frame_host.h"
 
 #if !defined(OS_ANDROID)
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/devtools_agent_host.h"
 #endif  // !defined(OS_ANDROID)
 
 ChromeDevToolsManagerDelegate::ChromeDevToolsManagerDelegate()
     : network_protocol_handler_(new DevToolsNetworkProtocolHandler()) {
 }
 
 ChromeDevToolsManagerDelegate::~ChromeDevToolsManagerDelegate() {
 }
 
 void ChromeDevToolsManagerDelegate::Inspect(
     content::BrowserContext* browser_context,
     content::DevToolsAgentHost* agent_host) {
 #if !defined(OS_ANDROID)
   content::DevToolsAgentHost::Type type = agent_host->GetType();
   if (type != content::DevToolsAgentHost::TYPE_SHARED_WORKER &&
       type != content::DevToolsAgentHost::TYPE_SERVICE_WORKER) {
     // TODO(horo): Support other types of DevToolsAgentHost when necessary.
     NOTREACHED() << "Inspect() only supports workers.";
   }
   if (Profile* profile = Profile::FromBrowserContext(browser_context))
     DevToolsWindow::OpenDevToolsWindowForWorker(profile, agent_host);
 #endif  // !defined(OS_ANDROID)
 }
 
+scoped_ptr<base::DictionaryValue> CanOpenAppBanner(

[pfeldman, 2016/01/14 04:43:05]

I am not sure we need this. Should we make it available at all times when
emulating?

[horo, 2016/01/15 10:00:22]

I think we should.
But AppBannerDataFetcherDesktop is created only when "enable-add-to-shelf" flag
is set.
So in this cl I want to show the error message if not enabled.
"Please check chrome://flags/#enable-add-to-shelf"

dfalcantara@, dominickn@
Do you have a plan to enable this flag by default for all platforms?

+    content::DevToolsAgentHost* agent_host,
+    int command_id,
+    base::DictionaryValue* params) {
+  scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue());
+  result->SetBoolean(chrome::devtools::kResult, true);
+  return DevToolsProtocol::CreateSuccessResponse(command_id, std::move(result));
+}
+
+scoped_ptr<base::DictionaryValue> OpenAppBanner(
+    content::DevToolsAgentHost* agent_host,
+    int command_id,
+    base::DictionaryValue* params) {
+  content::WebContents* web_contents = agent_host->GetWebContents();
+  content::RenderFrameHost* frame = web_contents->GetMainFrame();
+  banners::AppBannerManagerDesktop* manaager =

[pfeldman, 2016/01/14 04:43:05]

manager

[horo, 2016/01/15 10:00:22]

Done.

+      banners::AppBannerManagerDesktop::FromWebContents(web_contents);
+  if (manaager) {
+    manaager->TriggerAppBannerFetch(frame, frame->GetLastCommittedURL(), true);
+  }
+  scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue());
+  result->SetBoolean(chrome::devtools::kResult, true);
+  return DevToolsProtocol::CreateSuccessResponse(command_id, std::move(result));
+}
+
 base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand(
     content::DevToolsAgentHost* agent_host,
     base::DictionaryValue* command_dict) {
-  return network_protocol_handler_->HandleCommand(agent_host, command_dict);
+  base::DictionaryValue* ret =
+      network_protocol_handler_->HandleCommand(agent_host, command_dict);
+  if (ret)
+    return ret;
+  {

[pfeldman, 2016/01/14 04:43:05]

why new scope?

[horo, 2016/01/15 10:00:22]

Removed.
Sorry this was still a WIP patch.

+    int id = 0;

[pfeldman, 2016/01/14 04:43:05]

This already has happened in the network handler. Should we crack the command
here and pass the id/method/params into network handler? Or even better dispatch
commands here and make explicit calls into network_handler / app banner methods.

[horo, 2016/01/15 10:00:22]

Done.

+    std::string method;
+    base::DictionaryValue* params = nullptr;
+    if (!DevToolsProtocol::ParseCommand(command_dict, &id, &method, &params))
+      return nullptr;
+    namespace page = ::chrome::devtools::Page;
+    if (method == page::canOpenAppBanner::kName)
+      return CanOpenAppBanner(agent_host, id, params).release();
+    if (method == page::openAppBanner::kName)
+      return OpenAppBanner(agent_host, id, params).release();
+  }
+  return nullptr;
 }
 
 void ChromeDevToolsManagerDelegate::DevToolsAgentStateChanged(
     content::DevToolsAgentHost* agent_host,
     bool attached) {
   network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached);
 }