Add some corner cases for resynthesis of field formal parameters.

Add some corner cases for resynthesis of field formal parameters.

Field formal parameters have some strange behaviors because they are
the only thing in the language where the implicit type (if not
specified) is not necessarily `dynamic`.  So we should be careful to
test that we resynthesize them properly.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5c46fee9fab41d1fbdffc1f4ce9bd97734657ec5

[Paul Berry, 2016-01-07 17:42:57]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-01-07 17:44:24]

LGTM

[Brian Wilkerson, 2016-01-07 17:46:15]

> Field formal parameters have some strange behaviors because they are
> the only thing in the language where the implicit type (if not specified) is
> not necessarily `dynamic`.

Strong mode's inference of member types has a similar behavior. Not sure how
that impacts summaries.

[Paul Berry, 2016-01-07 17:53:14]

On 2016/01/07 17:46:15, Brian Wilkerson wrote:
> > Field formal parameters have some strange behaviors because they are
> > the only thing in the language where the implicit type (if not specified) is
> > not necessarily `dynamic`.
> 
> Strong mode's inference of member types has a similar behavior. Not sure how
> that impacts summaries.

Yeah, I'm not sure yet either.  I'm hoping we can make some progress on figuring
it out next week.

[Paul Berry, 2016-01-07 18:42:17]

Description was changed from

==========
Add some corner cases for resynthesis of field formal parameters.

Field formal parameters have some strange behaviors because they are
the only thing in the language where the implicit type (if not
specified) is not necessarily `dynamic`.  So we should be careful to
test that we resynthesize them properly.
==========

to

==========
Add some corner cases for resynthesis of field formal parameters.

Field formal parameters have some strange behaviors because they are
the only thing in the language where the implicit type (if not
specified) is not necessarily `dynamic`.  So we should be careful to
test that we resynthesize them properly.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5c46fee9fab41d1fbdffc1f4ce9bd97734657ec5
==========

[Paul Berry, 2016-01-07 18:42:18]

Committed patchset #1 (id:1) manually as
5c46fee9fab41d1fbdffc1f4ce9bd97734657ec5 (presubmit successful).