Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: net/tools/quic/end_to_end_test.cc

Issue 1569853005: relnote: Require QUIC handshakes to require either a valid server nonce or a remote strike register. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_CL_111655037
Patch Set: rebase after remove 111628983 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_flags.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <sys/epoll.h> 6 #include <sys/epoll.h>
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 793 matching lines...) Expand 10 before | Expand all | Expand 10 after
804 client_->client()->session()->GetNumSentClientHellos()); 804 client_->client()->session()->GetNumSentClientHellos());
805 EXPECT_EQ(2, client_->client()->GetNumSentClientHellos()); 805 EXPECT_EQ(2, client_->client()->GetNumSentClientHellos());
806 806
807 client_->Disconnect(); 807 client_->Disconnect();
808 808
809 // The 0-RTT handshake should succeed. 809 // The 0-RTT handshake should succeed.
810 client_->Connect(); 810 client_->Connect();
811 client_->WaitForResponseForMs(-1); 811 client_->WaitForResponseForMs(-1);
812 ASSERT_TRUE(client_->client()->connected()); 812 ASSERT_TRUE(client_->client()->connected());
813 EXPECT_EQ(kFooResponseBody, client_->SendCustomSynchronousRequest(request)); 813 EXPECT_EQ(kFooResponseBody, client_->SendCustomSynchronousRequest(request));
814 EXPECT_EQ(1, client_->client()->session()->GetNumSentClientHellos()); 814 if (FLAGS_require_strike_register_or_server_nonce) {
815 EXPECT_EQ(1, client_->client()->GetNumSentClientHellos()); 815 EXPECT_EQ(expected_num_hellos_latest_session,
816 client_->client()->session()->GetNumSentClientHellos());
817 EXPECT_EQ(2, client_->client()->GetNumSentClientHellos());
818 } else {
819 EXPECT_EQ(1, client_->client()->session()->GetNumSentClientHellos());
820 EXPECT_EQ(1, client_->client()->GetNumSentClientHellos());
821 }
816 822
817 client_->Disconnect(); 823 client_->Disconnect();
818 824
819 // Restart the server so that the 0-RTT handshake will take 1 RTT. 825 // Restart the server so that the 0-RTT handshake will take 1 RTT.
820 StopServer(); 826 StopServer();
821 server_writer_ = new PacketDroppingTestWriter(); 827 server_writer_ = new PacketDroppingTestWriter();
822 StartServer(); 828 StartServer();
823 829
824 client_->Connect(); 830 client_->Connect();
825 ASSERT_TRUE(client_->client()->connected()); 831 ASSERT_TRUE(client_->client()->connected());
(...skipping 30 matching lines...) Expand all
856 client_->client()->session()->GetNumSentClientHellos()); 862 client_->client()->session()->GetNumSentClientHellos());
857 EXPECT_EQ(2, client_->client()->GetNumSentClientHellos()); 863 EXPECT_EQ(2, client_->client()->GetNumSentClientHellos());
858 864
859 client_->Disconnect(); 865 client_->Disconnect();
860 866
861 // The 0-RTT handshake should succeed. 867 // The 0-RTT handshake should succeed.
862 client_->Connect(); 868 client_->Connect();
863 client_->WaitForInitialResponse(); 869 client_->WaitForInitialResponse();
864 ASSERT_TRUE(client_->client()->connected()); 870 ASSERT_TRUE(client_->client()->connected());
865 EXPECT_EQ(kFooResponseBody, client_->SendSynchronousRequest("/foo")); 871 EXPECT_EQ(kFooResponseBody, client_->SendSynchronousRequest("/foo"));
866 EXPECT_EQ(1, client_->client()->session()->GetNumSentClientHellos()); 872 if (FLAGS_require_strike_register_or_server_nonce) {
867 EXPECT_EQ(1, client_->client()->GetNumSentClientHellos()); 873 EXPECT_EQ(expected_num_hellos_latest_session,
874 client_->client()->session()->GetNumSentClientHellos());
875 EXPECT_EQ(2, client_->client()->GetNumSentClientHellos());
876 } else {
877 EXPECT_EQ(1, client_->client()->session()->GetNumSentClientHellos());
878 EXPECT_EQ(1, client_->client()->GetNumSentClientHellos());
879 }
868 880
869 client_->Disconnect(); 881 client_->Disconnect();
870 882
871 // Restart the server so that the 0-RTT handshake will take 1 RTT. 883 // Restart the server so that the 0-RTT handshake will take 1 RTT.
872 StopServer(); 884 StopServer();
873 server_writer_ = new PacketDroppingTestWriter(); 885 server_writer_ = new PacketDroppingTestWriter();
874 StartServer(); 886 StartServer();
875 887
876 client_->Connect(); 888 client_->Connect();
877 ASSERT_TRUE(client_->client()->connected()); 889 ASSERT_TRUE(client_->client()->connected());
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
914 client_->client()->session()->GetNumSentClientHellos()); 926 client_->client()->session()->GetNumSentClientHellos());
915 EXPECT_EQ(2, client_->client()->GetNumSentClientHellos()); 927 EXPECT_EQ(2, client_->client()->GetNumSentClientHellos());
916 928
917 client_->Disconnect(); 929 client_->Disconnect();
918 930
919 // The 0-RTT handshake should succeed. 931 // The 0-RTT handshake should succeed.
920 client_->Connect(); 932 client_->Connect();
921 client_->WaitForInitialResponse(); 933 client_->WaitForInitialResponse();
922 ASSERT_TRUE(client_->client()->connected()); 934 ASSERT_TRUE(client_->client()->connected());
923 EXPECT_EQ(kFooResponseBody, client_->SendCustomSynchronousRequest(request)); 935 EXPECT_EQ(kFooResponseBody, client_->SendCustomSynchronousRequest(request));
924 EXPECT_EQ(1, client_->client()->session()->GetNumSentClientHellos()); 936 if (FLAGS_require_strike_register_or_server_nonce) {
925 EXPECT_EQ(1, client_->client()->GetNumSentClientHellos()); 937 EXPECT_EQ(expected_num_hellos_latest_session,
938 client_->client()->session()->GetNumSentClientHellos());
939 EXPECT_EQ(2, client_->client()->GetNumSentClientHellos());
940 } else {
941 EXPECT_EQ(1, client_->client()->session()->GetNumSentClientHellos());
942 EXPECT_EQ(1, client_->client()->GetNumSentClientHellos());
943 }
926 944
927 client_->Disconnect(); 945 client_->Disconnect();
928 946
929 // Restart the server so that the 0-RTT handshake will take 1 RTT. 947 // Restart the server so that the 0-RTT handshake will take 1 RTT.
930 StopServer(); 948 StopServer();
931 server_writer_ = new PacketDroppingTestWriter(); 949 server_writer_ = new PacketDroppingTestWriter();
932 StartServer(); 950 StartServer();
933 951
934 client_->Connect(); 952 client_->Connect();
935 ASSERT_TRUE(client_->client()->connected()); 953 ASSERT_TRUE(client_->client()->connected());
(...skipping 1213 matching lines...) Expand 10 before | Expand all | Expand 10 after
2149 2167
2150 EXPECT_EQ(kBody, client_->SendSynchronousRequest("/trailer_url")); 2168 EXPECT_EQ(kBody, client_->SendSynchronousRequest("/trailer_url"));
2151 EXPECT_EQ(200u, client_->response_headers()->parsed_response_code()); 2169 EXPECT_EQ(200u, client_->response_headers()->parsed_response_code());
2152 EXPECT_EQ(trailers, client_->response_trailers()); 2170 EXPECT_EQ(trailers, client_->response_trailers());
2153 } 2171 }
2154 2172
2155 } // namespace 2173 } // namespace
2156 } // namespace test 2174 } // namespace test
2157 } // namespace tools 2175 } // namespace tools
2158 } // namespace net 2176 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_flags.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698