Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1569853004: Refresh Public Suffic List to the latest version (Closed)

Created:
4 years, 11 months ago by Ryan Sleevi
Modified:
4 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffic List to the latest version This updates from revision df1735751c24e736018dc51f1be7dea686b6304 (2015-11-12) to revision 3594dcfbd8cf1cb3ba2c57bd56b761147ea31fca (2016-01-04) R=pkasting@chromium.org BUG=37436 Committed: https://crrev.com/c9c3a6826ed14badab06650e1346f3545546273f Cr-Commit-Position: refs/heads/master@{#368490}

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -27 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.dat View 24 chunks +81 lines, -18 lines 6 comments Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 43 chunks +43 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Ryan Sleevi
Nothing exciting this time
4 years, 11 months ago (2016-01-08 22:09:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569853004/1
4 years, 11 months ago (2016-01-08 22:11:52 UTC) #3
Peter Kasting
LGTM with some comments to maybe take upstream https://codereview.chromium.org/1569853004/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/1569853004/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode8330 net/base/registry_controlled_domains/effective_tld_names.dat:8330: // ...
4 years, 11 months ago (2016-01-09 00:31:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-09 00:36:30 UTC) #6
Ryan Sleevi
https://codereview.chromium.org/1569853004/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/1569853004/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode8330 net/base/registry_controlled_domains/effective_tld_names.dat:8330: // hiv : 2014-03-13 On 2016/01/09 00:31:14, Peter Kasting ...
4 years, 11 months ago (2016-01-09 00:43:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569853004/1
4 years, 11 months ago (2016-01-09 00:44:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-09 00:50:06 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-09 00:52:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9c3a6826ed14badab06650e1346f3545546273f
Cr-Commit-Position: refs/heads/master@{#368490}

Powered by Google App Engine
This is Rietveld 408576698