Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 1569833004: Fix unref order in SkGpuDevice (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M src/gpu/SkGpuDevice.h View 1 3 chunks +8 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
joshualitt
4 years, 11 months ago (2016-01-07 21:56:54 UTC) #3
robertphillips
lgtm + nits https://codereview.chromium.org/1569833004/diff/1/src/gpu/SkGpuDevice.h File src/gpu/SkGpuDevice.h (right): https://codereview.chromium.org/1569833004/diff/1/src/gpu/SkGpuDevice.h#newcode56 src/gpu/SkGpuDevice.h:56: Shouldn't this actually be override ? ...
4 years, 11 months ago (2016-01-07 22:08:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569833004/20001
4 years, 11 months ago (2016-01-08 14:08:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569833004/20001
4 years, 11 months ago (2016-01-08 14:30:27 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 14:32:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/06dd0a8222cc97236a2d20d563e27995983e6e0c

Powered by Google App Engine
This is Rietveld 408576698