Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1569833003: Adds strict compilation flags to Dart_IsolateFlags (Closed)

Created:
4 years, 11 months ago by zra
Modified:
4 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adds strict compilation flags to Dart_IsolateFlags Also removes the API call for setting these, which is no longer needed. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/97158fed8c0d072084e056314357b4283928c097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -55 lines) Patch
M runtime/include/dart_api.h View 2 chunks +2 lines, -13 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 2 chunks +40 lines, -14 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 11 months ago (2016-01-07 18:48:10 UTC) #2
Ivan Posva
LGTM -ip
4 years, 11 months ago (2016-01-08 08:43:26 UTC) #3
zra
4 years, 11 months ago (2016-01-08 17:55:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
97158fed8c0d072084e056314357b4283928c097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698