Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: net/quic/quic_connection.h

Issue 1569823008: relnote: Merge all fields of QueuedPacket into SerializedPacket. No functional change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: track previous cl Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index ac1b284cb27d028dfcbe8270de4bb4b1c55abd1c..9077b620ab4f99f44edc7c138e90aee6555fdbfb 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -636,20 +636,6 @@ class NET_EXPORT_PRIVATE QuicConnection
bool ack_frame_updated() const;
protected:
- // Packets which have not been written to the wire.
- struct QueuedPacket {
- explicit QueuedPacket(SerializedPacket packet);
- QueuedPacket(SerializedPacket packet,
- TransmissionType transmission_type,
- QuicPacketNumber original_packet_number);
-
- SerializedPacket serialized_packet;
- TransmissionType transmission_type;
- // The packet's original packet number if it is a retransmission.
- // Otherwise it must be 0.
- QuicPacketNumber original_packet_number;
- };
-
// Do any work which logically would be done in OnPacket but can not be
// safely done until the packet is validated. Returns true if the packet
// can be handled, false otherwise. Also migrates the connection if the packet
@@ -658,7 +644,7 @@ class NET_EXPORT_PRIVATE QuicConnection
// Send a packet to the peer, and takes ownership of the packet if the packet
// cannot be written immediately.
- virtual void SendOrQueuePacket(QueuedPacket packet);
+ virtual void SendOrQueuePacket(SerializedPacket* packet);
QuicConnectionHelperInterface* helper() { return helper_; }
@@ -682,7 +668,7 @@ class NET_EXPORT_PRIVATE QuicConnection
friend class test::QuicConnectionPeer;
friend class test::PacketSavingConnection;
- typedef std::list<QueuedPacket> QueuedPacketList;
+ typedef std::list<SerializedPacket> QueuedPacketList;
typedef std::map<QuicFecGroupNumber, QuicFecGroup*> FecGroupMap;
// Writes the given packet to socket, encrypted with packet's
@@ -692,11 +678,11 @@ class NET_EXPORT_PRIVATE QuicConnection
// retransmittable frames to nullptr.
// Saves the connection close packet for later transmission, even if the
// writer is write blocked.
- bool WritePacket(QueuedPacket* packet);
+ bool WritePacket(SerializedPacket* packet);
// Does the main work of WritePacket, but does not delete the packet or
// retransmittable frames upon success.
- bool WritePacketInner(QueuedPacket* packet);
+ bool WritePacketInner(SerializedPacket* packet);
// Make sure an ack we got from our peer is sane.
// Returns nullptr for valid acks or an error std::string if it was invalid.
@@ -714,7 +700,7 @@ class NET_EXPORT_PRIVATE QuicConnection
// Clears any accumulated frames from the last received packet.
void ClearLastFrames();
- // Deletes and clears any QueuedPackets.
+ // Deletes and clears any queued packets.
void ClearQueuedPackets();
// Closes the connection if the sent or received packet manager are tracking
@@ -729,7 +715,7 @@ class NET_EXPORT_PRIVATE QuicConnection
void WritePendingRetransmissions();
// Returns true if the packet should be discarded and not sent.
- bool ShouldDiscardPacket(const QueuedPacket& packet);
+ bool ShouldDiscardPacket(const SerializedPacket& packet);
// Queues |packet| in the hopes that it can be decrypted in the
// future, when a new key is installed.
@@ -782,8 +768,8 @@ class NET_EXPORT_PRIVATE QuicConnection
void CheckForAddressMigration(const IPEndPoint& self_address,
const IPEndPoint& peer_address);
- HasRetransmittableData IsRetransmittable(const QueuedPacket& packet);
- bool IsTerminationPacket(const QueuedPacket& packet);
+ HasRetransmittableData IsRetransmittable(const SerializedPacket& packet);
+ bool IsTerminationPacket(const SerializedPacket& packet);
// Set the size of the packet we are targeting while doing path MTU discovery.
void SetMtuDiscoveryTarget(QuicByteCount target);
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698