Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1569793002: Clarify the description of what a suggestion is in the context of the NTP. (Closed)

Created:
4 years, 11 months ago by knn
Modified:
4 years, 11 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify the description of what a suggestion is in the context of the NTP. It is not clear to the translators what a suggestion is as each string is translated separately. BUG=565953 Committed: https://crrev.com/29df095fdb8b76b37bdab5b438471dfe2985b4b6 Cr-Commit-Position: refs/heads/master@{#368050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
knn
PTAL. Thanks!
4 years, 11 months ago (2016-01-07 07:45:49 UTC) #2
Bernhard Bauer
LGTM (I personally am of the opinion that chrome://flags shouldn't get localized at all, because ...
4 years, 11 months ago (2016-01-07 10:06:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569793002/1
4 years, 11 months ago (2016-01-07 10:24:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 11:13:27 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 11:14:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29df095fdb8b76b37bdab5b438471dfe2985b4b6
Cr-Commit-Position: refs/heads/master@{#368050}

Powered by Google App Engine
This is Rietveld 408576698