Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1569783006: Bump the version number and re-baseline codegen/expect (Closed)

Created:
4 years, 11 months ago by Leaf
Modified:
4 years, 11 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bump the version number and re-baseline codegen/expect BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ea12b1a44c535d3a771adbba6b843e856383f497

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1280 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/devc.dart View 1 chunk +1 line, -1 line 0 comments Download
M package.json View 1 chunk +1 line, -1 line 1 comment Download
M pubspec.yaml View 2 chunks +2 lines, -1 line 0 comments Download
D test/codegen/expect/collection/src/queue_list.js View 1 chunk +0 lines, -235 lines 0 comments Download
D test/codegen/expect/collection/src/unmodifiable_wrappers.js View 1 chunk +0 lines, -229 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
D test/codegen/expect/collection/wrappers.js View 1 chunk +0 lines, -810 lines 0 comments Download
M test/codegen/expect/collection/wrappers.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/language-all.js View Binary file 0 comments Download
A test/codegen/expect/script.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M tool/test.sh View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
4 years, 11 months ago (2016-01-08 21:24:23 UTC) #2
vsm
lgtm https://codereview.chromium.org/1569783006/diff/20001/package.json File package.json (left): https://codereview.chromium.org/1569783006/diff/20001/package.json#oldcode3 package.json:3: "version": "0.1.0", oops
4 years, 11 months ago (2016-01-08 21:25:59 UTC) #3
Leaf
4 years, 11 months ago (2016-01-08 21:29:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ea12b1a44c535d3a771adbba6b843e856383f497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698