Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3366)

Unified Diff: chrome/android/java/res/layout/web_notification_big.xml

Issue 1569783005: Notification custom layouts: move settings button to the footer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/values-v17/styles.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/web_notification_big.xml
diff --git a/chrome/android/java/res/layout/web_notification_big.xml b/chrome/android/java/res/layout/web_notification_big.xml
index f02f716c49fb7ab1175726f180c22772efc738e7..fc476e7f1678ef6a64bb93e26182e187bc947e3a 100644
--- a/chrome/android/java/res/layout/web_notification_big.xml
+++ b/chrome/android/java/res/layout/web_notification_big.xml
@@ -13,10 +13,10 @@
|________| if there is a lot of it. |
| __________________________________________|
| |
- | Button Button Settings |
+ | Button Button |
| __________________________________________|
| |
- | www.example.com |
+ | ⛭ www.example.com |
|_____________________________________________________|
-->
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
@@ -121,16 +121,24 @@
android:id="@+id/footer_divider"
android:layout_width="match_parent"
android:layout_height="1dp"
- android:layout_marginBottom="8dp"
android:contentDescription="@null"
style="@style/WebNotificationDivider"/>
<RelativeLayout
android:layout_width="match_parent"
- android:layout_height="wrap_content"
- android:layout_marginBottom="10dp">
+ android:layout_height="wrap_content">
- <TextView
+ <ImageView
+ android:id="@+id/origin_settings_icon"
+ android:layout_width="wrap_content"
+ android:layout_height="40dp"
+ android:layout_alignParentStart="true"
+ android:layout_alignParentTop="true"
+ android:contentDescription="@null"
+ android:src="@drawable/settings_cog"
+ android:scaleType="centerInside"/>
+
+ <Button
android:id="@+id/origin"
android:layout_width="match_parent"
android:layout_height="wrap_content"
@@ -138,9 +146,12 @@
android:layout_alignParentStart="true"
android:layout_alignParentTop="true"
android:layout_toStartOf="@+id/small_icon_footer"
+ android:minHeight="40dp"
+ android:gravity="start|center_vertical"
+ android:paddingStart="32dp"
android:singleLine="true"
android:ellipsize="start"
- style="@style/WebNotificationOrigin"/>
+ style="@style/WebNotificationSettingsButton"/>
<ViewStub
android:id="@id/small_icon_footer"
@@ -150,7 +161,7 @@
android:layout_height="16dp"
android:layout_marginEnd="8dp"
android:layout_alignParentEnd="true"
- android:layout_alignParentTop="true"/>
+ android:layout_centerVertical="true"/>
</RelativeLayout>
« no previous file with comments | « no previous file | chrome/android/java/res/values-v17/styles.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698