ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc - Issue 15697019: Parametrize names of llc and ld nexes by reading them from the resource info JSON file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

Issue 15697019: Parametrize names of llc and ld nexes by reading them from the resource info JSON file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tweak comments some more, following Jan's review Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/trusted/plugin/pnacl_resources.cc ('k') | ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_info_template.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

index e035ce10dc05997f57a72f975a2f391e83377c39..7b1a680dffb7962556e53772f5e3a36f283f9e21 100644

--- a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

+++ b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

@@ -135,7 +135,7 @@ void PnaclTranslateThread::DoTranslate() {

nacl::MutexLocker ml(&subprocess_mu_);

int64_t llc_start_time = NaClGetTimeOfDayMicroseconds();

llc_subprocess_.reset(

- StartSubprocess(PnaclUrls::GetLlcUrl(), manifest_, &error_info));

+ StartSubprocess(resources_->GetLlcUrl(), manifest_, &error_info));

if (llc_subprocess_ == NULL) {

TranslateFailed(ERROR_PNACL_LLC_SETUP,

"Compile process could not be created: " +

@@ -278,7 +278,7 @@ bool PnaclTranslateThread::RunLdSubprocess(int is_shared_library,

nacl::MutexLocker ml(&subprocess_mu_);

int64_t ld_start_time = NaClGetTimeOfDayMicroseconds();

ld_subprocess_.reset(

- StartSubprocess(PnaclUrls::GetLdUrl(), manifest_, &error_info));

+ StartSubprocess(resources_->GetLdUrl(), manifest_, &error_info));

if (ld_subprocess_ == NULL) {

TranslateFailed(ERROR_PNACL_LD_SETUP,

"Link process could not be created: " +